HomePhabricator

Fix uninitialized g_connman crash in Shutdown()

Description

Fix uninitialized g_connman crash in Shutdown()

Summary:
Under some circumstances if an error occurs at init, a segfault is
raised at shutdown.

Backport of core PR11326

Test Plan:

./src/bitcoind -wallet=/tmp/wallet.dat (the file should not exist)

Check that an error is shown and:

  • before the patch, the app gets a segfault
  • after the patch, the app shuts down properly

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2392

Details

Provenance
MeshCollider <dobsonsa68@gmail.com>Authored on Sep 14 2017, 03:18
FabienCommitted on Jan 23 2019, 16:52
jasonbcoxPushed on Jan 23 2019, 19:19
Reviewer
Restricted Project
Differential Revision
D2392: Fix uninitialized g_connman crash in Shutdown()
Parents
rSTAGINGa22e27b29162: Add a check-doc exception for -greatwallactivationtime
Branches
Unknown
Tags
Unknown