Differential D10026

[avalanche] Make gen_proof facility return the key object
ClosedPublic
Actions

Authored by Fabien on Sep 2 2021, 13:00.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC6a6a8b6e61fd: [avalanche] Make gen_proof facility return the key object

Summary

There is currently a single callsite using the private key output, which is retuned as wif. Returning the key object makes it more versatile as the pubkey can be computed as needed as well. This will be used in an upcoming new test.

Ref T1634.

Test Plan

ninja all check-all
./test/functional/test_runner.py abc_p2p_proof_inventory

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 2 2021, 13:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 2 2021, 13:00

Fabien requested review of this revision.Sep 2 2021, 13:01

Harbormaster completed remote builds in B16526: Diff 29749.Sep 2 2021, 13:23

majcosta accepted this revision.Sep 2 2021, 13:33

This revision is now accepted and ready to land.Sep 2 2021, 13:33

Fabien added a child revision: D10027: [avalanche] Add conflicting proofs to the vote.Sep 2 2021, 13:45

Closed by commit rABC6a6a8b6e61fd: [avalanche] Make gen_proof facility return the key object (authored by Fabien). · Explain WhySep 2 2021, 13:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6a6a8b6e61fd: [avalanche] Make gen_proof facility return the key object.

Fabien removed a child revision: D10027: [avalanche] Add conflicting proofs to the vote.Sep 23 2021, 13:12

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_proof_inventory.py

2 lines

test_framework/

avatools.py

4 lines

Diff 29751

View Options

test/functional/abc_p2p_proof_inventory.py