Page MenuHomePhabricator
Differential D10031

[avalanche] Order the peer set by score
ClosedPublic
Actions

Authored by Fabien on Sep 3 2021, 11:59.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC93920f6bb44c: [avalanche] Order the peer set by score
Summary

This diff adds an ordered view to the peer set so that highest scores are placed first. This will be useful for selecting the peers we want to get nodes for.

Another diff will cache the score so it's not recomputed every time when it's not needed.

Ref T1864.

Test Plan
ninja check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_peers_ordered_by_score
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16534
Build 32930: Build Difflint-circular-dependencies · build-without-wallet · build-debug · build-clang-tidy · build-clang · build-diff
Build 32929: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 3 2021, 11:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2021, 11:59
Fabien requested review of this revision.Sep 3 2021, 11:59
Harbormaster completed remote builds in B16534: Diff 29767.Sep 3 2021, 12:17
Fabien mentioned this in D10032: [avalanche] Cache the peer score.Sep 3 2021, 13:33
PiRK accepted this revision.Sep 3 2021, 14:46
This revision is now accepted and ready to land.Sep 3 2021, 14:46
Fabien updated this revision to Diff 29776.Sep 3 2021, 20:24

Improve the test variable name and make it easier to read what is the expected ordering. No change in behavior.

Fabien added a child revision: Restricted Differential Revision.Sep 3 2021, 20:29
Harbormaster completed remote builds in B16542: Diff 29776.Sep 3 2021, 20:39
Fabien planned changes to this revision.Sep 28 2021, 19:05
Fabien updated this revision to Diff 30941.Nov 23 2021, 13:28
Fabien edited the summary of this revision. (Show Details)
Fabien added a task: Restricted Maniphest Task.

Rebase and repurpose (summary update only).

This revision is now accepted and ready to land.Nov 23 2021, 13:28
Harbormaster completed remote builds in B17305: Diff 30941.Nov 23 2021, 13:44
Fabien planned changes to this revision.Jan 28 2022, 19:17
Fabien updated this revision to Diff 32507.Feb 23 2022, 17:43

Rebase

This revision is now accepted and ready to land.Feb 23 2022, 17:43
Harbormaster completed remote builds in B18350: Diff 32507.Feb 23 2022, 17:59
Fabien updated this revision to Diff 32512.Feb 24 2022, 08:18

Fix a typo

Harbormaster completed remote builds in B18354: Diff 32512.Feb 24 2022, 08:34
Fabien edited the summary of this revision. (Show Details)Feb 24 2022, 13:50
Fabien added a task: Restricted Maniphest Task.
Fabien removed a task: Restricted Maniphest Task.Feb 24 2022, 14:00
Closed by commit rABC93920f6bb44c: [avalanche] Order the peer set by score (authored by Fabien). · Explain WhyFeb 24 2022, 14:01
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC93920f6bb44c: [avalanche] Order the peer set by score.
Fabien mentioned this in rABCa839bb735777: [avalanche] Cache the peer score.Feb 24 2022, 14:07
tyler-smith added a child revision: D11101: [avalanche] Don't poll or vote definitively until we have quorum..Feb 28 2022, 07:18

Revision Contents
Changeset List

PathSize
src/
avalanche/
11 lines
test/
36 lines

Diff 29767

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...