Page MenuHomePhabricator
Differential D10038

walletdb: Remove BerkeleyBatch friend class from BerkeleyDatabase
ClosedPublic
Actions

Authored by PiRK on Sep 3 2021, 17:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5cbb600772e0: walletdb: Remove BerkeleyBatch friend class from BerkeleyDatabase
Summary

This is a backport of core#19335 [5/5]
https://github.com/bitcoin/bitcoin/pull/19335/commits/74507ce71eb61105fb3ae8460999099234ca7b8b

Depends on D10037

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 3 2021, 17:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2021, 17:11
PiRK requested review of this revision.Sep 3 2021, 17:11
teamcity edited the summary of this revision. (Show Details)Sep 3 2021, 17:12
Harbormaster completed remote builds in B16541: Diff 29775.Sep 3 2021, 17:43
deadalnix accepted this revision.Sep 5 2021, 19:54
This revision is now accepted and ready to land.Sep 5 2021, 19:54
PiRK updated this revision to Diff 29796.Sep 6 2021, 12:44

rebase

Harbormaster completed remote builds in B16557: Diff 29796.Sep 6 2021, 13:11
teamcity added a comment.Sep 6 2021, 13:11
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

rpc_preciousblock.py                    | ✓ Passed  | 1 s
rpc_psbt.py                             | ✓ Passed  | 35 s
rpc_rawtransaction.py                   | ✓ Passed  | 13 s
rpc_scantxoutset.py                     | ✓ Passed  | 3 s
rpc_setban.py                           | ✓ Passed  | 2 s
rpc_signmessage.py                      | ✓ Passed  | 1 s
rpc_signrawtransaction.py               | ✓ Passed  | 1 s
rpc_txoutproof.py                       | ✓ Passed  | 2 s
rpc_uptime.py                           | ✓ Passed  | 1 s
rpc_users.py                            | ✓ Passed  | 5 s
rpc_whitelist.py                        | ✓ Passed  | 1 s
tool_wallet.py                          | ✓ Passed  | 4 s
wallet_abandonconflict.py               | ✓ Passed  | 8 s
wallet_address_types.py                 | ✓ Passed  | 14 s
wallet_avoidreuse.py                    | ✓ Passed  | 3 s
wallet_backup.py                        | ✓ Passed  | 27 s
wallet_balance.py                       | ✓ Passed  | 13 s
wallet_basic.py                         | ✓ Passed  | 28 s
wallet_coinbase_category.py             | ✓ Passed  | 1 s
wallet_create_tx.py                     | ✓ Passed  | 5 s
wallet_createwallet.py                  | ✓ Passed  | 2 s
wallet_createwallet.py --usecli         | ✓ Passed  | 3 s
wallet_descriptor.py                    | ✓ Passed  | 9 s
wallet_disable.py                       | ✓ Passed  | 0 s
wallet_dump.py                          | ✓ Passed  | 4 s
wallet_encryption.py                    | ✓ Passed  | 5 s
wallet_hd.py                            | ✓ Passed  | 6 s
wallet_import_rescan.py                 | ✓ Passed  | 4 s
wallet_import_with_label.py             | ✓ Passed  | 1 s
wallet_importdescriptors.py             | ✓ Passed  | 4 s
wallet_importmulti.py                   | ✓ Passed  | 3 s
wallet_importprunedfunds.py             | ✓ Passed  | 2 s
wallet_keypool.py                       | ✓ Passed  | 3 s
wallet_keypool_topup.py                 | ✓ Passed  | 2 s
wallet_labels.py                        | ✓ Passed  | 1 s
wallet_listreceivedby.py                | ✓ Passed  | 23 s
wallet_listsinceblock.py                | ✓ Passed  | 3 s
wallet_listtransactions.py              | ✓ Passed  | 9 s
wallet_multiwallet.py                   | ✓ Passed  | 39 s
wallet_multiwallet.py --usecli          | ✓ Passed  | 16 s
wallet_reorgsrestore.py                 | ✓ Passed  | 3 s
wallet_resendwallettransactions.py      | ✓ Passed  | 6 s
wallet_txn_clone.py                     | ✓ Passed  | 2 s
wallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
wallet_txn_doublespend.py               | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
wallet_watchonly.py                     | ✓ Passed  | 1 s
wallet_watchonly.py --usecli            | ✓ Passed  | 1 s
wallet_zapwallettxes.py                 | ✓ Passed  | 3 s

ALL                                     | ✓ Passed  | 995 s (accumulated) 
Runtime: 199 s

----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK updated this revision to Diff 29798.Sep 6 2021, 14:26

unable to reproduce CI failure, and it happened on a "blank" diff (rebase).
Try to rebase again, on latest master.

PiRK added a child revision: D10048: Introduce DummyDatabase and use it in the tests.Sep 6 2021, 14:27
Harbormaster completed remote builds in B16559: Diff 29798.Sep 6 2021, 14:36
Closed by commit rABC5cbb600772e0: walletdb: Remove BerkeleyBatch friend class from BerkeleyDatabase (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhySep 6 2021, 16:04
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5cbb600772e0: walletdb: Remove BerkeleyBatch friend class from BerkeleyDatabase.

Revision Contents
Changeset List

PathSize
src/
wallet/
6 lines

Diff 29810

View Options

src/wallet/bdb.h

Loading...