Page MenuHomePhabricator
Differential D10036

walletdb: Move Db->open to BerkeleyDatabase::Open
ClosedPublic
Actions

Authored by PiRK on Sep 3 2021, 17:08.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC2a0157d45a65: walletdb: Move Db->open to BerkeleyDatabase::Open
Summary

Instead of opening the Db handle in BerkeleyBatch, make BerkeleyDatabase
do that.

This is a backport of core#19335 [3/5]
https://github.com/bitcoin/bitcoin/pull/19335/commits/d86efab37002841fd059251672e1ec1a977b743f

Depends on D10035

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 3 2021, 17:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2021, 17:08
PiRK requested review of this revision.Sep 3 2021, 17:08
teamcity edited the summary of this revision. (Show Details)Sep 3 2021, 17:09
PiRK added a child revision: D10037: No need to check for duplicate fileids in all dbenvs.Sep 3 2021, 17:10
Harbormaster completed remote builds in B16539: Diff 29773.Sep 3 2021, 17:26
Fabien added a subscriber: Fabien.Sep 6 2021, 09:11
Fabien added inline comments.
src/wallet/bdb.cpp
425 ↗(On Diff #29773)

Where does this change comes from ? It's not in the PR and if this is a linter change it is weird

448 ↗(On Diff #29773)

Same question

629 ↗(On Diff #29773)

dito

645 ↗(On Diff #29773)

dito

PiRK updated this revision to Diff 29793.Sep 6 2021, 12:10

attempt to undo comment linting (lines not touched by the original PR)

Harbormaster completed remote builds in B16554: Diff 29793.Sep 6 2021, 12:35
PiRK added a comment.Sep 6 2021, 12:45

The problem was that during conflict resolution I forgot to close a bracket, so the linter indented the rest of the file and changed the layout. I then fixed the indentation issue, but did not notice the layout changes.

majcosta accepted this revision.Sep 6 2021, 15:14
This revision is now accepted and ready to land.Sep 6 2021, 15:14
Closed by commit rABC2a0157d45a65: walletdb: Move Db->open to BerkeleyDatabase::Open (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhySep 6 2021, 16:01
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2a0157d45a65: walletdb: Move Db->open to BerkeleyDatabase::Open.

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
80 lines

Diff 29808

View Options

src/wallet/bdb.h

Loading...
View Options

src/wallet/bdb.cpp

Loading...