Page MenuHomePhabricator

walletdb: Move Db->open to BerkeleyDatabase::Open
ClosedPublic

Authored by PiRK on Fri, Sep 3, 17:08.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC2a0157d45a65: walletdb: Move Db->open to BerkeleyDatabase::Open
Summary

Instead of opening the Db handle in BerkeleyBatch, make BerkeleyDatabase
do that.

This is a backport of core#19335 [3/5]
https://github.com/bitcoin/bitcoin/pull/19335/commits/d86efab37002841fd059251672e1ec1a977b743f

Depends on D10035

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Fri, Sep 3, 17:08
Fabien added inline comments.
src/wallet/bdb.cpp
425 ↗(On Diff #29773)

Where does this change comes from ? It's not in the PR and if this is a linter change it is weird

448 ↗(On Diff #29773)

Same question

629 ↗(On Diff #29773)

dito

645 ↗(On Diff #29773)

dito

attempt to undo comment linting (lines not touched by the original PR)

The problem was that during conflict resolution I forgot to close a bracket, so the linter indented the rest of the file and changed the layout. I then fixed the indentation issue, but did not notice the layout changes.

This revision is now accepted and ready to land.Mon, Sep 6, 15:14