Differential D10043

Update the signed message prefix to eCash
ClosedPublic
Actions

Authored by Fabien on Sep 5 2021, 08:51.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC2d8ce90df555: Update the signed message prefix to eCash

Summary

Rebrand the message prefix to eCash rather than bitcoin. Since I'm not aware of any use case for keeping the legacy prefix I added to compatibility flag, but only a release note.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash_signed_message

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16547
Build 32954: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang · build-debug
Build 32953: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 5 2021, 08:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2021, 08:51

Fabien requested review of this revision.Sep 5 2021, 08:51

Note to reviewers: the release notes obviously needs a rebase after D10042 is landed

Harbormaster completed remote builds in B16547: Diff 29781.Sep 5 2021, 09:08

deadalnix accepted this revision.Sep 5 2021, 19:50

This revision is now accepted and ready to land.Sep 5 2021, 19:50

I will do something similar with Electrum ABC. But I'm wondering if it wouldn't make more sense to support both schemes, at least for signature verification.

Closed by commit rABC2d8ce90df555: Update the signed message prefix to eCash (authored by Fabien). · Explain WhySep 6 2021, 08:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2d8ce90df555: Update the signed message prefix to eCash.