Cleanup Bitcoin Cash user agents in seeder tests
ClosedPublic
Actions

Authored by thonkle on Sep 13 2021, 22:09.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC53e80d9b2ea5: Cleanup Bitcoin Cash user agents in seeder tests

Summary

Coupled with D10104 and D10105, BCH references in the seeder should be cleaned up
and rebranded to eCash (or Bitcoin ABC as determined by the node).

Test Plan

ninja check-seeder

Diff Detail

Repository

rABC Bitcoin ABC

Branch

seeder-useragent-test

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16630
Build 33115: Build Diff	build-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-clang
Build 33114: arc lint + arc unit

Event Timeline

thonkle created this revision.Sep 13 2021, 22:09

Owners added a reviewer: Restricted Owners Package.Sep 13 2021, 22:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2021, 22:09

thonkle requested review of this revision.Sep 13 2021, 22:09

Harbormaster completed remote builds in B16630: Diff 29926.Sep 13 2021, 22:23

Fabien accepted this revision.Sep 14 2021, 09:16

This revision is now accepted and ready to land.Sep 14 2021, 09:16

Closed by commit rABC53e80d9b2ea5: Cleanup Bitcoin Cash user agents in seeder tests (authored by thonkle). · Explain WhySep 14 2021, 17:52

This revision was automatically updated to reflect the committed changes.

thonkle added a commit: rABC53e80d9b2ea5: Cleanup Bitcoin Cash user agents in seeder tests.

Revision Contents
Changeset List

Path

Size

src/

seeder/

test/

message_writer_tests.cpp

2 lines

p2p_messaging_tests.cpp

2 lines

Diff 29926

View Options

src/seeder/test/message_writer_tests.cpp