chain: Remove UB CChain comparison
ClosedPublic
Actions

Authored by PiRK on Sep 16 2021, 12:11.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCba848a43e275: chain: Remove UB CChain comparison

Summary

It was unused, and had UB

This is a backport of core#19822

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19822

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16672
Build 33199: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-diff · build-debug · build-clang
Build 33198: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 16 2021, 12:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2021, 12:11

PiRK requested review of this revision.Sep 16 2021, 12:11

teamcity edited the summary of this revision. (Show Details)Sep 16 2021, 12:12

Harbormaster completed remote builds in B16672: Diff 29994.Sep 16 2021, 12:24

Fabien accepted this revision.Sep 16 2021, 12:31

This revision is now accepted and ready to land.Sep 16 2021, 12:31

Closed by commit rABCba848a43e275: chain: Remove UB CChain comparison (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhySep 16 2021, 13:24

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCba848a43e275: chain: Remove UB CChain comparison.

Revision Contents
Changeset List

Path

Size

src/

chain.h

6 lines

Diff 29994

View Options

chain: Remove UB CChain comparisonClosedPublicActions