Page MenuHomePhabricator
Differential D10136

doc: Document differences in bitcoind and bitcoin-qt locale handling
ClosedPublic
Actions

Authored by PiRK on Sep 16 2021, 14:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC59661fd89e69: doc: Document differences in bitcoind and bitcoin-qt locale handling
Summary

Document differences in bitcoind and bitcoin-qt locale handling.

Since this seems to be the root cause to the locale dependency issues we've seen over the years I thought it was worth documenting

This is a backport of core#18817

Test Plan

proofreading

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr18817
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningarcanist/linter/LocaleDependenceLinter.php:32PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warningarcanist/linter/LocaleDependenceLinter.php:33PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warningarcanist/linter/LocaleDependenceLinter.php:34PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Unit
No Test Coverage
Build Status
Buildable 16677
Build 33209: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 33208: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 16 2021, 14:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2021, 14:50
PiRK requested review of this revision.Sep 16 2021, 14:50
Harbormaster completed remote builds in B16677: Diff 30005.Sep 16 2021, 14:50
teamcity edited the summary of this revision. (Show Details)Sep 16 2021, 14:51
Fabien requested changes to this revision.Sep 16 2021, 20:22
Fabien added a subscriber: Fabien.

Please fix the linter issues

This revision now requires changes to proceed.Sep 16 2021, 20:22
PiRK updated this revision to Diff 30017.Sep 17 2021, 06:16

Fix linter issues (lines too long)

Harbormaster completed remote builds in B16683: Diff 30017.Sep 17 2021, 06:44
Fabien accepted this revision.Sep 17 2021, 09:19
This revision is now accepted and ready to land.Sep 17 2021, 09:19
• boardgamesaz added a subscriber: • boardgamesaz.Sep 17 2021, 10:13
This comment was removed by Mengerian.
Closed by commit rABC59661fd89e69: doc: Document differences in bitcoind and bitcoin-qt locale handling (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by PiRK). · Explain WhySep 17 2021, 11:44
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC59661fd89e69: doc: Document differences in bitcoind and bitcoin-qt locale handling.
Mengerian added a subscriber: Mengerian.Mar 30 2022, 14:01

Revision Contents
Changeset List

PathSize
arcanist/
linter/
32 lines
src/
qt/
1 line

Diff 30005

View Options

arcanist/linter/LocaleDependenceLinter.php

Loading...
View Options

src/qt/bitcoin.cpp

Loading...