Details

Reviewers

Group Reviewers

Restricted Project

Commits

Summary

This introduces a minimalistic test wallet, which can be used as a drop in replacement for the Bitcoin Core wallet to create dummy transactions with a given fee rate.

This is a backport of core#19800

It is squashed with the first bugfix commit of core#19922:
https://github.com/bitcoin/bitcoin/pull/19922/commits/fa65a11d0c9a34ff7f4cc4efd53367794e751749

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19800

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16886
Build 33611: Build Diff	build-without-wallet · build-clang · build-clang-tidy · build-diff · build-debug
Build 33610: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 24 2021, 19:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 24 2021, 19:20

PiRK requested review of this revision.Sep 24 2021, 19:20

teamcity edited the summary of this revision. (Show Details)Sep 24 2021, 19:20

PiRK added inline comments.Sep 24 2021, 19:25

test/functional/test_framework/wallet.py
68 ↗	(On Diff #30162)	I found that most transactions are 207 bytes in size, but occasionaly there is one that is 206 bytes. I don't know if there are other sizes possible. I have not been able to see any other value in a loop of 100 executions of the tests.

PiRK edited the summary of this revision. (Show Details)Sep 24 2021, 19:26

Harbormaster completed remote builds in B16782: Diff 30162.Sep 24 2021, 19:30

Fabien requested changes to this revision.Sep 27 2021, 09:39

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/test_framework/wallet.py
28 ↗	(On Diff #30162)	You're missing a backport here

This revision now requires changes to proceed.Sep 27 2021, 09:39

rebase on D10247, use ADDRESS_P2SH_OP_TRUE instead of signing a regular p2pkh, move SCRIPTSIG_OP_TRUE to address.py

Harbormaster completed remote builds in B16885: Diff 30317.Oct 5 2021, 14:46

use correct size for fee computation, subtract 1 when calling pad_tx

squash with the bugfix commit https://github.com/bitcoin/bitcoin/pull/19922/commits/fa65a11d0c9a34ff7f4cc4efd53367794e751749

Harbormaster completed remote builds in B16886: Diff 30318.Oct 5 2021, 15:55

Fabien requested changes to this revision.Oct 6 2021, 14:02

Fabien added inline comments.

test/functional/test_framework/wallet.py
55	If `pad_tx` ALWAYS overpads by 1 byte, then the fix should trivial. If `pad_tx` SOMETIMES overpads by 1 byte, then this will fail occasionally. What is the situation ?

This revision now requires changes to proceed.Oct 6 2021, 14:02

PiRK added inline comments.Oct 6 2021, 14:14

test/functional/test_framework/wallet.py
55	For this particular transaction size it overpads always by exactly 1 byte. I need to dive deeper into the issue to find out exactly what is happening for larger sizes (>172 if I remember correctly).