Page MenuHomePhabricator

Address nits in ADDR caching
ClosedPublic

Authored by PiRK on Fri, Oct 8, 14:28.

Details

Reviewers
Fabien
baby636
Group Reviewers
Restricted Project
Commits
rABC74c406fc1673: Address nits in ADDR caching
Summary
Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Fri, Oct 8, 14:28

Tail of the build log:

[396/455] bitcoin: testing cuckoocache_tests
[397/455] bitcoin: testing merkleblock_tests
[398/455] bitcoin: testing finalization_tests
[399/455] Running utility command for check-bitcoin-cuckoocache_tests
[400/455] Running utility command for check-bitcoin-merkleblock_tests
[401/455] Running utility command for check-bitcoin-finalization_tests
[402/455] bitcoin: testing scheduler_tests
[403/455] bitcoin: testing bip32_tests
[404/455] bitcoin: testing txvalidationcache_tests
[405/455] Running utility command for check-bitcoin-scheduler_tests
[406/455] Running utility command for check-bitcoin-bip32_tests
[407/455] Running utility command for check-bitcoin-txvalidationcache_tests
[408/455] bitcoin: testing sync_tests
[409/455] bitcoin: testing op_reversebytes_tests
[410/455] bitcoin: testing torcontrol_tests
[411/455] Running utility command for check-bitcoin-sync_tests
[412/455] Running utility command for check-bitcoin-torcontrol_tests
[413/455] Running utility command for check-bitcoin-op_reversebytes_tests
[414/455] bitcoin: testing settings_tests
[415/455] Running utility command for check-bitcoin-settings_tests
[416/455] bitcoin: testing streams_tests
[417/455] bitcoin: testing timedata_tests
[418/455] Running utility command for check-bitcoin-streams_tests
[419/455] bitcoin: testing compilerbug_tests
[420/455] bitcoin: testing validation_flush_tests
[421/455] Running utility command for check-bitcoin-timedata_tests
[422/455] Running utility command for check-bitcoin-compilerbug_tests
[423/455] Running utility command for check-bitcoin-validation_flush_tests
[424/455] bitcoin: testing checkpoints_tests
[425/455] Running utility command for check-bitcoin-checkpoints_tests
[426/455] bitcoin: testing serialize_tests
[427/455] bitcoin: testing schnorr_tests
[428/455] Running utility command for check-bitcoin-serialize_tests
[429/455] bitcoin: testing validationinterface_tests
[430/455] Running utility command for check-bitcoin-schnorr_tests
[431/455] bitcoin: testing transaction_tests
[432/455] bitcoin: testing blockstatus_tests
[433/455] Running utility command for check-bitcoin-validationinterface_tests
[434/455] Running utility command for check-bitcoin-transaction_tests
[435/455] Running utility command for check-bitcoin-blockstatus_tests
[436/455] bitcoin: testing cashaddr_tests
[437/455] Running utility command for check-bitcoin-cashaddr_tests
[438/455] bitcoin: testing versionbits_tests
[439/455] Running utility command for check-bitcoin-versionbits_tests
[440/455] bitcoin: testing script_tests
[441/455] Running utility command for check-bitcoin-script_tests
[442/455] bitcoin: testing crypto_tests
[443/455] Running utility command for check-bitcoin-crypto_tests
[444/455] bitcoin: testing monolith_opcodes_tests
[445/455] Running utility command for check-bitcoin-monolith_opcodes_tests
[446/455] bitcoin: testing intmath_tests
[447/455] bitcoin: testing blockcheck_tests
[448/455] Running utility command for check-bitcoin-intmath_tests
[449/455] Running utility command for check-bitcoin-blockcheck_tests
[450/455] bitcoin: testing coinselector_tests
[451/455] Running utility command for check-bitcoin-coinselector_tests
[452/455] bitcoin: testing coins_tests
[453/455] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
Fabien requested changes to this revision.Fri, Oct 8, 19:45
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net.cpp
2897 ↗(On Diff #30395)

Why did you change the comment ? It is more clear in the PR imo

This revision now requires changes to proceed.Fri, Oct 8, 19:45
src/net.cpp
2897 ↗(On Diff #30395)

I will revert, then. I don't have a strong opinion, I just felt that the comment in the PR made less sense if not added in-line.

use exact same commit as in PR

This revision is now accepted and ready to land.Mon, Oct 11, 13:14
This revision was automatically updated to reflect the committed changes.