Differential D10300

[avalanche] Use a consistent and well known proof master in proof tests
ClosedPublic
Actions

Authored by Fabien on Oct 11 2021, 12:59.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC4cbb93880201: [avalanche] Use a consistent and well known proof master in proof tests

Summary

The private key associated with the proof master for some test vectors is unknown. This makes it impossible to introduce the proof signature without having to change this key, which this diff does. This makes it easier to review the changes when the proof signature is introduced.

Since changing the proof master will change the proof id, the vectors where the verification result is expected to be valid needs to update the stake signature as well.

The review may show a lot of changes for some vectors because they were using an uncompressed pubkey, and the new one is compressed causing the hex to get unaligned.

Ref T1676.

Test Plan

ninja check-avalanche-proof_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_proof_test_master_key

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16956
Build 33748: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 33747: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 11 2021, 12:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 11 2021, 12:59

Fabien requested review of this revision.Oct 11 2021, 12:59

Fabien mentioned this in D10140: [avalanche] Sign the avalanche proof.Oct 11 2021, 13:03

Fabien added a child revision: D10140: [avalanche] Sign the avalanche proof.Oct 11 2021, 13:04

Harbormaster completed remote builds in B16956: Diff 30418.Oct 11 2021, 13:19

Reviewed by concatenating multiline proofs to a single one-line string:

arc patch D10300
git checkout 5fcbf32ac0223dc742ef744dc36378cba736ef3e     # previous commit
cat src/avalanche/test/proof_tests.cpp  | tr '\n' '@' | sed 's/"@ *"//g' | tr '@' '\n' >  before.cpp
git checkout arcpatch-D10300
cat src/avalanche/test/proof_tests.cpp  | tr '\n' '@' | sed 's/"@ *"//g' | tr '@' '\n' >  after.cpp
gvimdiff before.cpp after.cpp

PiRK accepted this revision.Oct 11 2021, 19:41

This revision is now accepted and ready to land.Oct 11 2021, 19:41

Closed by commit rABC4cbb93880201: [avalanche] Use a consistent and well known proof master in proof tests (authored by Fabien). · Explain WhyOct 12 2021, 08:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4cbb93880201: [avalanche] Use a consistent and well known proof master in proof tests.