Page MenuHomePhabricator
Differential D10309

Rename voteItemTestingContexts => voteItemProviders, because they provide vote items
ClosedPublic
Actions

Authored by deadalnix on Oct 12 2021, 12:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC640de372ab14: Rename voteItemTestingContexts => voteItemProviders, because they provide vote…
Summary

And if they provide vote items, they should be called vote item providers

Test Plan
ninja check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 12 2021, 12:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2021, 12:08
deadalnix requested review of this revision.Oct 12 2021, 12:08
deadalnix updated this revision to Diff 30451.

Use using instead of typedef and use the proper naming convention for types.

Harbormaster completed remote builds in B16971: Diff 30450.Oct 12 2021, 12:24
Harbormaster completed remote builds in B16972: Diff 30451.Oct 12 2021, 12:31
Fabien accepted this revision.Oct 12 2021, 12:32
Fabien added a subscriber: Fabien.

Indeed that's a better name

This revision is now accepted and ready to land.Oct 12 2021, 12:32
Closed by commit rABC640de372ab14: Rename voteItemTestingContexts => voteItemProviders, because they provide vote… (authored by deadalnix). · Explain WhyOct 12 2021, 12:54
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC640de372ab14: Rename voteItemTestingContexts => voteItemProviders, because they provide vote….

Revision Contents
Changeset List

PathSize
src/
avalanche/
test/
120 lines

Diff 30456

View Options

src/avalanche/test/processor_tests.cpp

Loading...