Differential D10312

translation.h from proof.h
ClosedPublic
Actions

Authored by deadalnix on Oct 12 2021, 12:50.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd6aef46579c3: Do not include util/system.h and util/translation.h from proof.h

Summary

They are actually not needed, so let's not.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

proofarg

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16976
Build 33788: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 33787: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 12 2021, 12:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2021, 12:50

deadalnix requested review of this revision.Oct 12 2021, 12:50

Rebase

Fabien accepted this revision.Oct 12 2021, 13:00

This revision is now accepted and ready to land.Oct 12 2021, 13:00

Harbormaster completed remote builds in B16975: Diff 30454.Oct 12 2021, 13:03

This revision was landed with ongoing or failed builds.Oct 12 2021, 13:06

Closed by commit rABCd6aef46579c3: Do not include util/system.h and util/translation.h from proof.h (authored by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCd6aef46579c3: Do not include util/system.h and util/translation.h from proof.h.

Harbormaster completed remote builds in B16976: Diff 30458.Oct 12 2021, 13:33

Revision Contents
Changeset List

Path

Size

src/

avalanche/

proof.h

12 lines

proof.cpp

11 lines

proofbuilder.cpp

1 line

test/

peermanager_tests.cpp

1 line

rpc/

avalanche.cpp

1 line

Diff 30458

View Options

src/avalanche/proof.h

View Options

src/avalanche/proof.cpp

View Options

src/avalanche/proofbuilder.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

View Options

Do not include util/system.h and util/translation.h from proof.hClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30458

src/avalanche/proof.h

src/avalanche/proof.cpp

src/avalanche/proofbuilder.cpp

src/avalanche/test/peermanager_tests.cpp

src/rpc/avalanche.cpp

Do not include util/system.h and util/translation.h from proof.h
ClosedPublic
Actions

Revision Contents
Changeset List