HomePhabricator

Fix abc-invalid-message.py flakiness

Description

Fix abc-invalid-message.py flakiness

Summary:
The test will fail occasionally, especially on OSX. This is due to a peer disconnection happening before the connection check completed.
This diff delays sending the invalid message and prevents this wrong operation ordering.

Note that I couldn't reproduce the issue locally, but at least this doesn't make things worst.

Test Plan:
In a loop:

./test/functional/test_runner.py abc-invalid-message

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D10302

Details

Provenance
FabienAuthored on Oct 12 2021, 08:16
FabienPushed on Oct 12 2021, 11:48
Reviewer
Restricted Project
Differential Revision
D10302: Fix abc-invalid-message.py flakiness
Parents
rABC4cbb93880201: [avalanche] Use a consistent and well known proof master in proof tests
Branches
Unknown
Tags
Unknown