Page MenuHomePhabricator

Fix abc-invalid-message.py flakiness
ClosedPublic

Authored by Fabien on Tue, Oct 12, 08:20.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCb04fcc9242d2: Fix abc-invalid-message.py flakiness
Summary

The test will fail occasionally, especially on OSX. This is due to a peer disconnection happening before the connection check completed.
This diff delays sending the invalid message and prevents this wrong operation ordering.

Note that I couldn't reproduce the issue locally, but at least this doesn't make things worst.

Test Plan

In a loop:

./test/functional/test_runner.py abc-invalid-message

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Tue, Oct 12, 08:20
Fabien retitled this revision from Fix abc-invlaid-message.py flakiness to Fix abc-invalid-message.py flakiness.Tue, Oct 12, 08:55
This revision is now accepted and ready to land.Tue, Oct 12, 11:32
This revision was automatically updated to reflect the committed changes.