Page MenuHomePhabricator
Differential D10302

Fix abc-invalid-message.py flakiness
ClosedPublic
Actions

Authored by Fabien on Oct 12 2021, 08:20.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCb04fcc9242d2: Fix abc-invalid-message.py flakiness
Summary

The test will fail occasionally, especially on OSX. This is due to a peer disconnection happening before the connection check completed.
This diff delays sending the invalid message and prevents this wrong operation ordering.

Note that I couldn't reproduce the issue locally, but at least this doesn't make things worst.

Test Plan

In a loop:

./test/functional/test_runner.py abc-invalid-message

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 12 2021, 08:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2021, 08:20
Fabien requested review of this revision.Oct 12 2021, 08:20
Fabien retitled this revision from Fix abc-invlaid-message.py flakiness to Fix abc-invalid-message.py flakiness.Oct 12 2021, 08:55
Harbormaster completed remote builds in B16961: Diff 30430.Oct 12 2021, 08:59
deadalnix accepted this revision.Oct 12 2021, 11:32
This revision is now accepted and ready to land.Oct 12 2021, 11:32
Closed by commit rABCb04fcc9242d2: Fix abc-invalid-message.py flakiness (authored by Fabien). · Explain WhyOct 12 2021, 11:48
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb04fcc9242d2: Fix abc-invalid-message.py flakiness.

Revision Contents
Changeset List

PathSize
test/
functional/
23 lines

Diff 30449

View Options

test/functional/abc-invalid-message.py

Loading...