Differential D10350

Set result_emulated to a value that is known to be wrong in intmath_tests.cpp
ClosedPublic
Actions

Authored by deadalnix on Oct 14 2021, 16:30.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCddb609db747c: Set result_emulated to a value that is known to be wrong in intmath_tests.cpp

Summary

Computation is done using unsigned, so that overflow is not UB.

Test Plan

ninja check

Also do it using ubsan

Diff Detail

Repository

rABC Bitcoin ABC

Branch

initresult_emulated

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17034
Build 33902: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang · build-diff · build-clang-tidy · build-debug
Build 33901: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 14 2021, 16:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2021, 16:30

deadalnix requested review of this revision.Oct 14 2021, 16:30

Harbormaster completed remote builds in B17034: Diff 30555.Oct 14 2021, 16:46

Fabien accepted this revision.Oct 14 2021, 18:54

This revision is now accepted and ready to land.Oct 14 2021, 18:54

Closed by commit rABCddb609db747c: Set result_emulated to a value that is known to be wrong in intmath_tests.cpp (authored by deadalnix). · Explain WhyOct 14 2021, 20:03

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCddb609db747c: Set result_emulated to a value that is known to be wrong in intmath_tests.cpp.

Revision Contents
Changeset List

Path

Size

src/

test/

intmath_tests.cpp

6 lines

Diff 30555

View Options

src/test/intmath_tests.cpp

Set result_emulated to a value that is known to be wrong in intmath_tests.cppClosedPublicActions