Page MenuHomePhabricator
Differential D10372

[rpc] Add connection type to getpeerinfo RPC, update tests
ClosedPublic
Actions

Authored by PiRK on Oct 21 2021, 15:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2df9a7a6b5c1: [rpc] Add connection type to getpeerinfo RPC, update tests
Summary

This is a backport of core#19725 [2/5]
https://github.com/bitcoin/bitcoin/pull/19725/commits/395acfa83a5436790c1a722a5609ac9d48df235f

Depends on D10371

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 21 2021, 15:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2021, 15:24
PiRK requested review of this revision.Oct 21 2021, 15:25
teamcity edited the summary of this revision. (Show Details)Oct 21 2021, 15:25
PiRK edited the summary of this revision. (Show Details)Oct 21 2021, 15:25
PiRK added a parent revision: D10371: [log] Add connection type to log statement.
PiRK added a child revision: D10373: [refactor] Rename test file to allow any getpeerinfo deprecations..
Harbormaster completed remote builds in B17082: Diff 30622.Oct 21 2021, 15:42
Fabien requested changes to this revision.Oct 22 2021, 09:35
Fabien mentioned this in D10374: [rpc] Deprecate getpeerinfo addnode field.
Fabien added a subscriber: Fabien.

The release notes are missing, see D10374

This revision now requires changes to proceed.Oct 22 2021, 09:35
PiRK updated this revision to Diff 30649.Oct 22 2021, 11:48

add related lease notes here instead of D10374

Harbormaster completed remote builds in B17108: Diff 30649.Oct 22 2021, 12:02
Fabien accepted this revision.Oct 25 2021, 08:04
This revision is now accepted and ready to land.Oct 25 2021, 08:04
Closed by commit rABC2df9a7a6b5c1: [rpc] Add connection type to getpeerinfo RPC, update tests (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by PiRK). · Explain WhyOct 28 2021, 13:57
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2df9a7a6b5c1: [rpc] Add connection type to getpeerinfo RPC, update tests.

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
9 lines
2 lines
rpc/
4 lines
test/
functional/
6 lines

Diff 30682

View Options

doc/release-notes.md

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

test/functional/rpc_net.py

Loading...