Page MenuHomePhabricator
Differential D10374

[rpc] Deprecate getpeerinfo addnode field
ClosedPublic
Actions

Authored by PiRK on Oct 21 2021, 15:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd88621364524: [rpc] Deprecate getpeerinfo addnode field
Summary

This field is now redundant since the connection type field will indicate
MANUAL for addnode connections.

This is a backport of core#19725 [4&5/5]
https://github.com/bitcoin/bitcoin/pull/19725/commits/50f94b34a33c954f6e207f509c93d33267a5c3e2
https://github.com/bitcoin/bitcoin/pull/19725/commits/a512925e19a70d7f6b80ac530a169f45ffaafa1c

Depends on D10373

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 21 2021, 15:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2021, 15:28
PiRK requested review of this revision.Oct 21 2021, 15:28
teamcity edited the summary of this revision. (Show Details)Oct 21 2021, 15:28
PiRK added a child revision: D10375: [doc] Release notes.Oct 21 2021, 15:29
Harbormaster completed remote builds in B17084: Diff 30624.Oct 21 2021, 15:54
PiRK updated this revision to Diff 30643.Oct 22 2021, 06:50
PiRK edited the summary of this revision. (Show Details)

squash D10374 & D10375 (release notes)

PiRK mentioned this in D10375: [doc] Release notes.Oct 22 2021, 06:51
Harbormaster completed remote builds in B17102: Diff 30643.Oct 22 2021, 07:17
Fabien requested changes to this revision.Oct 22 2021, 09:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-notes.md
11 ↗(On Diff #30643)

This belongs in D10372

This revision now requires changes to proceed.Oct 22 2021, 09:35
Fabien mentioned this in D10372: [rpc] Add connection type to getpeerinfo RPC, update tests.Oct 22 2021, 09:35
PiRK updated this revision to Diff 30650.Oct 22 2021, 11:49

move half of the release notes to D10372

Harbormaster completed remote builds in B17109: Diff 30650.Oct 22 2021, 12:07
Fabien requested changes to this revision.Oct 25 2021, 08:08
Fabien added inline comments.
src/rpc/net.cpp
155 ↗(On Diff #30650)

You just duplicated the param

270 ↗(On Diff #30650)

removal in v0.25.x is enough

This revision now requires changes to proceed.Oct 25 2021, 08:08
PiRK updated this revision to Diff 30677.Oct 28 2021, 07:35

remove accidentaly duplicated addnode parameter, and change comment to suggest removal of deprecated argument in 0.25.x

Harbormaster completed remote builds in B17125: Diff 30677.Oct 28 2021, 07:49
Fabien accepted this revision.Oct 28 2021, 12:15
This revision is now accepted and ready to land.Oct 28 2021, 12:15
Closed by commit rABCd88621364524: [rpc] Deprecate getpeerinfo addnode field (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by PiRK). · Explain WhyOct 28 2021, 13:56
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd88621364524: [rpc] Deprecate getpeerinfo addnode field.

Revision Contents
Changeset List

PathSize
doc/
5 lines
src/
rpc/
9 lines
test/
functional/
14 lines

Diff 30680

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

test/functional/rpc_getpeerinfo_deprecation.py

Loading...