Page MenuHomePhabricator

[rpc] Deprecate getpeerinfo addnode field
ClosedPublic

Authored by PiRK on Oct 21 2021, 15:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd88621364524: [rpc] Deprecate getpeerinfo addnode field
Summary

This field is now redundant since the connection type field will indicate
MANUAL for addnode connections.

This is a backport of core#19725 [4&5/5]
https://github.com/bitcoin/bitcoin/pull/19725/commits/50f94b34a33c954f6e207f509c93d33267a5c3e2
https://github.com/bitcoin/bitcoin/pull/19725/commits/a512925e19a70d7f6b80ac530a169f45ffaafa1c

Depends on D10373

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Oct 21 2021, 15:28
PiRK edited the summary of this revision. (Show Details)

squash D10374 & D10375 (release notes)

Fabien requested changes to this revision.Oct 22 2021, 09:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-notes.md
11

This belongs in D10372

This revision now requires changes to proceed.Oct 22 2021, 09:35

move half of the release notes to D10372

Fabien requested changes to this revision.Oct 25 2021, 08:08
Fabien added inline comments.
src/rpc/net.cpp
155 ↗(On Diff #30650)

You just duplicated the param

270 ↗(On Diff #30650)

removal in v0.25.x is enough

This revision now requires changes to proceed.Oct 25 2021, 08:08

remove accidentaly duplicated addnode parameter, and change comment to suggest removal of deprecated argument in 0.25.x

This revision is now accepted and ready to land.Oct 28 2021, 12:15