Page MenuHomePhabricator
Differential D10378

[avalanche] Determine proof acceptance status from the peer manager
ClosedPublic
Actions

Authored by Fabien on Oct 21 2021, 16:07.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC7ee4daf36673: [avalanche] Determine proof acceptance status from the peer manager
Summary

Rather than supplying the acceptance status to addProofToReconcile(), extract it from the peer manager.

Ref T1854.

Depends on D10377.

Test Plan
ninja check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 21 2021, 16:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2021, 16:07
Fabien requested review of this revision.Oct 21 2021, 16:07
Harbormaster completed remote builds in B17093: Diff 30633.Oct 21 2021, 16:24
Fabien added a child revision: D10379: [avalanche] Avoid O(n2) when voting on proofs.Oct 21 2021, 16:57
deadalnix accepted this revision.Oct 21 2021, 20:21
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/processor.cpp
272 ↗(On Diff #30633)
bool isAccepted = WITH_LOCK(cs_peerManager, return peerManager->isValid(proof->getId());
This revision is now accepted and ready to land.Oct 21 2021, 20:21
Fabien removed a child revision: D10379: [avalanche] Avoid O(n2) when voting on proofs.Oct 22 2021, 09:08
Fabien added a child revision: D10379: [avalanche] Avoid O(n2) when voting on proofs.
Closed by commit rABC7ee4daf36673: [avalanche] Determine proof acceptance status from the peer manager (authored by Fabien). · Explain WhyOct 27 2021, 07:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7ee4daf36673: [avalanche] Determine proof acceptance status from the peer manager.

Revision Contents
Changeset List

PathSize
src/
avalanche/
2 lines
5 lines
test/
21 lines

Diff 30665

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...