Differential D10391

[avalanche] Slightly reduce cs_main scope in registerVotes
ClosedPublic
Actions

Authored by Fabien on Oct 27 2021, 15:29.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC3e2837934f84: [avalanche] Slightly reduce cs_main scope in registerVotes

Summary

This is a follow-up to D10379. Since IsWorthPolling() also requires the lock, the WITH_LOCK() macro is not used here. There is no change in behavior.

Ref T1854.

Depends on D10379.

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 27 2021, 15:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 27 2021, 15:29

Fabien requested review of this revision.Oct 27 2021, 15:29

Rebase properly

Harbormaster completed remote builds in B17121: Diff 30673.Oct 27 2021, 15:45

Harbormaster completed remote builds in B17122: Diff 30674.Oct 27 2021, 15:48

PiRK accepted this revision.Oct 28 2021, 13:48

This revision is now accepted and ready to land.Oct 28 2021, 13:48

Closed by commit rABC3e2837934f84: [avalanche] Slightly reduce cs_main scope in registerVotes (authored by Fabien). · Explain WhyNov 2 2021, 10:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3e2837934f84: [avalanche] Slightly reduce cs_main scope in registerVotes.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

23 lines

Diff 30726

View Options

src/avalanche/processor.cpp

[avalanche] Slightly reduce cs_main scope in registerVotesClosedPublicActions