Page MenuHomePhabricator

test: Get rid of default wallet hacks
ClosedPublic

Authored by PiRK on Nov 2 2021, 14:54.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCfecd97791cde: test: Get rid of default wallet hacks
Summary
  • Get rid of hardcoded wallet "" names and -wallet="" args
  • Get rid of setup_nodes (-wallet, -nowallet, -disablewallet) argument rewriting

Motivation:

  • Simplify test framework behavior so it's easier to write new tests without having arguments mangled by the framework
  • Make tests more readable, replacing unexplained "" string literals with default_wallet_name references
  • Make it trivial to update default wallet name and wallet data filename for sqlite #19077 testing
  • Stop relying on -wallet arguments to create wallets, so it is easy to change -wallet option in the future to only load existing wallets not create new ones (to avoid accidental wallet creation, and encourage use of wallet encryption and descriptor features)

This is a backport of core#20034 [2/2]
https://github.com/bitcoin/bitcoin/pull/20034/commits/c1585bca8dae01dee6a1dd8eadae2f8b100503df

Depends on D10421

Test Plan

ninja check-functional-extended

Diff Detail

Event Timeline

PiRK requested review of this revision.Nov 2 2021, 14:54
majcosta added a subscriber: majcosta.

feature_dbcrash won't run with ninja check-functional, test plan needs ./test/functional/test_runner.py --extended for that

This revision is now accepted and ready to land.Nov 2 2021, 20:14
This revision was automatically updated to reflect the committed changes.