Differential D10497

[avalanche] Remove the orphan pool in favor of a single proof pool
AbandonedPublic
Actions

Authored by Fabien on Nov 22 2021, 15:25.

Details

Reviewers

None

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Summary

The proof pool can take the role of the orphan proof pool entirely. This requires a few changes though:

an orphan is now defined as any proof in the pool that has no peer.
In order for a proof to be unorphaned we don't remove the proof from the pool when removing a peer
- dangling utxo is now a normal case and happens for each orphan, so the verify method needs to be updated.

This causes a change in behavior: there is a limiit in the number of proofs that can be conflicting per utxo, effectively limiting the depth of the "orphan pool" in a different way and requiring a test update.

Ref T1854.

Depends on D10493.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_peermanager_orphan_utxos

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17300
Build 34428: Build Diff	build-debug · build-diff · build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-clang
Build 34427: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 22 2021, 15:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2021, 15:25

Fabien requested review of this revision.Nov 22 2021, 15:25

Harbormaster completed remote builds in B17300: Diff 30934.Nov 22 2021, 15:38

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mrpc_signrawtransaction.py               | ✓ Passed  | 1 s
[0m[0;32mrpc_txoutproof.py                       | ✓ Passed  | 1 s
[0m[0;32mrpc_uptime.py                           | ✓ Passed  | 1 s
[0m[0;32mrpc_users.py                            | ✓ Passed  | 5 s
[0m[0;32mrpc_whitelist.py                        | ✓ Passed  | 1 s
[0m[0;32mtool_wallet.py                          | ✓ Passed  | 4 s
[0m[0;32mwallet_abandonconflict.py               | ✓ Passed  | 11 s
[0m[0;32mwallet_address_types.py                 | ✓ Passed  | 15 s
[0m[0;32mwallet_avoidreuse.py                    | ✓ Passed  | 4 s
[0m[0;32mwallet_avoidreuse.py --descriptors      | ✓ Passed  | 4 s
[0m[0;32mwallet_backup.py                        | ✓ Passed  | 28 s
[0m[0;32mwallet_balance.py                       | ✓ Passed  | 11 s
[0m[0;32mwallet_basic.py                         | ✓ Passed  | 25 s
[0m[0;32mwallet_coinbase_category.py             | ✓ Passed  | 1 s
[0m[0;32mwallet_create_tx.py                     | ✓ Passed  | 6 s
[0m[0;32mwallet_createwallet.py                  | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --usecli         | ✓ Passed  | 3 s
[0m[0;32mwallet_descriptor.py                    | ✓ Passed  | 6 s
[0m[0;32mwallet_disable.py                       | ✓ Passed  | 1 s
[0m[0;32mwallet_dump.py                          | ✓ Passed  | 5 s
[0m[0;32mwallet_encryption.py                    | ✓ Passed  | 5 s
[0m[0;32mwallet_encryption.py --descriptors      | ✓ Passed  | 5 s
[0m[0;32mwallet_hd.py                            | ✓ Passed  | 6 s
[0m[0;32mwallet_hd.py --descriptors              | ✓ Passed  | 5 s
[0m[0;32mwallet_import_rescan.py                 | ✓ Passed  | 5 s
[0m[0;32mwallet_import_with_label.py             | ✓ Passed  | 1 s
[0m[0;32mwallet_importdescriptors.py             | ✓ Passed  | 4 s
[0m[0;32mwallet_importmulti.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py             | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                       | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                 | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py --descriptors   | ✓ Passed  | 3 s
[0m[0;32mwallet_labels.py                        | ✓ Passed  | 2 s
[0m[0;32mwallet_labels.py --descriptors          | ✓ Passed  | 1 s
[0m[0;32mwallet_listreceivedby.py                | ✓ Passed  | 14 s
[0m[0;32mwallet_listsinceblock.py                | ✓ Passed  | 3 s
[0m[0;32mwallet_listtransactions.py              | ✓ Passed  | 14 s
[0m[0;32mwallet_multiwallet.py                   | ✓ Passed  | 41 s
[0m[0;32mwallet_multiwallet.py --usecli          | ✓ Passed  | 12 s
[0m[0;32mwallet_reorgsrestore.py                 | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py      | ✓ Passed  | 11 s
[0m[0;32mwallet_send.py                          | ✓ Passed  | 8 s
[0m[0;32mwallet_startup.py                       | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py                     | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py               | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                     | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli            | ✓ Passed  | 1 s
[0m[1m
ALL                                     | ✓ Passed  | 987 s (accumulated) 
[0mRuntime: 198 s

----------------------------------------------------------------------
Ran 10 tests in 0.093s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

unrelated failure, restarting the build

Fabien planned changes to this revision.Nov 24 2021, 08:28

Fabien abandoned this revision.Dec 14 2021, 15:56