Differential D10467
[avalanche] Let the PeerManager use the ProofPool Authored by Fabien on Nov 11 2021, 12:43.
Details
This diff replaces the utxos structure in the peer manager with the ProofPool. This pool is configured with a limited depth of a single proof per utxo, and the proof utxos attachment is made so that there is no change in behavior. The utxos attachement call is moved from createPeer() method to the registerProof() as it is about proof and not peer. Ref T1854. ninja all check-all
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log: [392/451] bitcoin: testing scheduler_tests [393/451] Running utility command for check-bitcoin-scheduler_tests [394/451] bitcoin: testing cuckoocache_tests [395/451] bitcoin: testing merkleblock_tests [396/451] Running utility command for check-bitcoin-cuckoocache_tests [397/451] bitcoin: testing bip32_tests [398/451] Running utility command for check-bitcoin-merkleblock_tests [399/451] bitcoin: testing sync_tests [400/451] Running utility command for check-bitcoin-bip32_tests [401/451] Running utility command for check-bitcoin-sync_tests [402/451] bitcoin: testing torcontrol_tests [403/451] Running utility command for check-bitcoin-torcontrol_tests [404/451] bitcoin: testing settings_tests [405/451] Running utility command for check-bitcoin-settings_tests [406/451] bitcoin: testing streams_tests [407/451] bitcoin: testing timedata_tests [408/451] Running utility command for check-bitcoin-streams_tests [409/451] Running utility command for check-bitcoin-timedata_tests [410/451] bitcoin: testing validation_flush_tests [411/451] Running utility command for check-bitcoin-validation_flush_tests [412/451] bitcoin: testing op_reversebytes_tests [413/451] bitcoin: testing compilerbug_tests [414/451] Running utility command for check-bitcoin-op_reversebytes_tests [415/451] bitcoin: testing blockcheck_tests [416/451] Running utility command for check-bitcoin-compilerbug_tests [417/451] Running utility command for check-bitcoin-blockcheck_tests [418/451] bitcoin: testing checkpoints_tests [419/451] bitcoin: testing serialize_tests [420/451] Running utility command for check-bitcoin-serialize_tests [421/451] Running utility command for check-bitcoin-checkpoints_tests [422/451] bitcoin: testing script_standard_tests [423/451] bitcoin: testing radix_tests [424/451] bitcoin: testing validationinterface_tests [425/451] Running utility command for check-bitcoin-script_standard_tests [426/451] bitcoin: testing schnorr_tests [427/451] Running utility command for check-bitcoin-validationinterface_tests [428/451] Running utility command for check-bitcoin-radix_tests [429/451] bitcoin: testing cashaddr_tests [430/451] bitcoin: testing script_tests [431/451] bitcoin: testing util_tests [432/451] bitcoin: testing transaction_tests [433/451] bitcoin: testing crypto_tests [434/451] Running utility command for check-bitcoin-schnorr_tests [435/451] Running utility command for check-bitcoin-cashaddr_tests [436/451] bitcoin: testing monolith_opcodes_tests [437/451] Running utility command for check-bitcoin-transaction_tests [438/451] Running utility command for check-bitcoin-util_tests [439/451] Running utility command for check-bitcoin-crypto_tests [440/451] bitcoin: testing versionbits_tests [441/451] Running utility command for check-bitcoin-script_tests [442/451] Running utility command for check-bitcoin-monolith_opcodes_tests [443/451] Running utility command for check-bitcoin-versionbits_tests [444/451] bitcoin: testing intmath_tests [445/451] Running utility command for check-bitcoin-intmath_tests [446/451] bitcoin: testing coinselector_tests [447/451] Running utility command for check-bitcoin-coinselector_tests [448/451] bitcoin: testing coins_tests [449/451] Running utility command for check-bitcoin-coins_tests ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1 Comment Actions Rebase, add missing dependency. This will also restart the test that failed for an unrelated reason. Comment Actions This is strictly more code and complexity to do the same thing, slower. I don't see what this brings to the table. The diffs description says what the cod does, which i already knew looking at the code, but in the absenc of a justification for this, I see no reason to even consider moving in that direction. This is strictly worse on all fronts.
| ||||||||||||||||||||||||||