Paths

Table of Contentst

Differential D10547

Implement SQLiteDatabase::Open
ClosedPublic
Actions

Authored by PiRK on Nov 25 2021, 16:25.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd5ebe098657a: Implement SQLiteDatabase::Open

Summary

This is a backport of core#19077 [7/26]
https://github.com/bitcoin/bitcoin/pull/19077/commits/a0de83372be83f59015cd3d61af2303b74fb64b5

Depends on D10546

Note: this uncomments the previously unused member vars m_mock (D10542) and m_database (D10545)

Test Plan

With clang-tidy:
ninja

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17372
Build 34572: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 34571: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 25 2021, 16:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2021, 16:26

PiRK requested review of this revision.Nov 25 2021, 16:26

teamcity edited the summary of this revision. (Show Details)Nov 25 2021, 16:26

move an inline comment to its own line

Harbormaster completed remote builds in B17372: Diff 31045.Nov 25 2021, 16:42

Harbormaster completed remote builds in B17373: Diff 31046.Nov 25 2021, 16:54

PiRK added a child revision: D10551: Implement SQLiteDatabase::Close.Nov 26 2021, 08:04

Fabien accepted this revision.Nov 26 2021, 13:13

This revision is now accepted and ready to land.Nov 26 2021, 13:13

Closed by commit rABCd5ebe098657a: Implement SQLiteDatabase::Open (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyNov 26 2021, 14:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd5ebe098657a: Implement SQLiteDatabase::Open.

Revision Contents
Changeset List

Path

Size

src/

wallet/

sqlite.h

6 lines

sqlite.cpp

115 lines

Diff 31045

View Options

src/wallet/sqlite.h