Differential D10557

[avalanche] Rename isValid => isBoundToPeer
ClosedPublic
Actions

Authored by Fabien on Nov 26 2021, 09:53.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC5e19f58d165b: [avalanche] Rename isValid => isBoundToPeer

Summary

This better reflects what this does, i.e. checking if a peer is bound to that proof.

Ref T1854.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 26 2021, 09:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2021, 09:53

Fabien requested review of this revision.Nov 26 2021, 09:54

Harbormaster completed remote builds in B17389: Diff 31064.Nov 26 2021, 10:14

isBoundToPeer is more accurate

deadalnix accepted this revision.Nov 26 2021, 14:23

This revision is now accepted and ready to land.Nov 26 2021, 14:23

Harbormaster completed remote builds in B17399: Diff 31085.Nov 26 2021, 14:53

Fabien retitled this revision from [avalanche] Rename isValid => isPeer to [avalanche] Rename isValid => isBoundToPeer.Nov 26 2021, 15:13

Closed by commit rABC5e19f58d165b: [avalanche] Rename isValid => isBoundToPeer (authored by Fabien). · Explain WhyNov 26 2021, 15:19

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5e19f58d165b: [avalanche] Rename isValid => isBoundToPeer.

Fabien mentioned this in D10522: [avalanche] Add wrappers to add and remove a proof from a proof pool.Nov 27 2021, 00:12

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.h

2 lines

peermanager.cpp

8 lines

processor.cpp

4 lines

test/

peermanager_tests.cpp

8 lines

net_processing.cpp

6 lines

Diff 31097

View Options

src/avalanche/peermanager.h

View Options

src/avalanche/peermanager.cpp

View Options

src/avalanche/processor.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

View Options

[avalanche] Rename isValid => isBoundToPeerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31097

src/avalanche/peermanager.h

src/avalanche/peermanager.cpp

src/avalanche/processor.cpp

src/avalanche/test/peermanager_tests.cpp

src/net_processing.cpp

[avalanche] Rename isValid => isBoundToPeer
ClosedPublic
Actions

Revision Contents
Changeset List