Paths

Table of Contentst

Differential D10559

test: Replace (dis)?connect_nodes globals with TestFramework methods
ClosedPublic
Actions

Authored by PiRK on Nov 26 2021, 13:37.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC00ae313d302f: test: Replace (dis)?connect_nodes globals with TestFramework methods

Summary

This is a semi-automatic regex text replacement (excluding files in the test_framework/ directory):
(dis)?connect_nodes\(self\.nodes\[(\d)\], self\.nodes\[(\d)\]\) --> self.$1connect_nodes($2, $3)

This is a backport of core#19967 [2/3]
https://github.com/bitcoin/bitcoin/pull/19967/commits/4b16c614616c1ff09e5b1dcd58516bcb9a88e5e8

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17392
Build 34612: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 34611: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 26 2021, 13:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2021, 13:37

PiRK requested review of this revision.Nov 26 2021, 13:37

teamcity edited the summary of this revision. (Show Details)Nov 26 2021, 13:37

Harbormaster completed remote builds in B17392: Diff 31067.Nov 26 2021, 13:52

PiRK added a child revision: D10560: test: Move (dis)?connect_nodes globals into TestFramework.Nov 26 2021, 13:54

Fabien accepted this revision.Nov 29 2021, 08:34

This revision is now accepted and ready to land.Nov 29 2021, 08:34

Closed by commit rABC00ae313d302f: test: Replace (dis)?connect_nodes globals with TestFramework methods (authored by PiRK). · Explain WhyNov 29 2021, 13:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC00ae313d302f: test: Replace (dis)?connect_nodes globals with TestFramework methods.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_mining_basic.py

8 lines

example_test.py

6 lines

feature_abortnode.py

4 lines

feature_bip68_sequence.py

6 lines

feature_minchainwork.py

4 lines

feature_notifications.py

13 lines

feature_pruning.py

30 lines

interface_zmq.py

19 lines

mempool_persist.py

6 lines

mining_basic.py

8 lines

p2p_blockfilters.py

6 lines

p2p_disconnect_ban.py

16 lines

p2p_node_network_limited.py

16 lines

p2p_permissions.py

6 lines

p2p_unrequested_blocks.py

8 lines

rpc_fundrawtransaction.py

9 lines

rpc_getblockfilter.py

6 lines

rpc_getpeerinfo_deprecation.py

3 lines

rpc_invalidateblock.py

6 lines

9 lines

rpc_preciousblock.py

8 lines

rpc_rawtransaction.py

3 lines

8 lines

wallet_abandonconflict.py

6 lines

wallet_address_types.py

8 lines

wallet_avoidreuse.py

3 lines

wallet_backup.py

22 lines

wallet_balance.py

8 lines

wallet_basic.py

21 lines

12 lines

wallet_import_rescan.py

4 lines

wallet_keypool_topup.py

6 lines

wallet_listsinceblock.py

3 lines

wallet_reorgsrestore.py

12 lines

wallet_txn_clone.py

6 lines

wallet_txn_doublespend.py

11 lines

Diff 31067

test/functional/abc_mining_basic.py

Loading...

test/functional/example_test.py

Loading...

test/functional/feature_abortnode.py

Loading...

test/functional/feature_bip68_sequence.py

Loading...

test/functional/feature_minchainwork.py

Loading...

test/functional/feature_notifications.py

Loading...

test/functional/feature_pruning.py

Loading...

test/functional/interface_zmq.py

Loading...

test/functional/mempool_persist.py

Loading...

test/functional/mining_basic.py

Loading...

test/functional/p2p_blockfilters.py

Loading...

test/functional/p2p_disconnect_ban.py

Loading...

test/functional/p2p_node_network_limited.py

Loading...

test/functional/p2p_permissions.py

Loading...

test/functional/p2p_unrequested_blocks.py

Loading...

test/functional/rpc_fundrawtransaction.py

Loading...

test/functional/rpc_getblockfilter.py

Loading...

test/functional/rpc_getpeerinfo_deprecation.py

Loading...

test/functional/rpc_invalidateblock.py

Loading...

test/functional/rpc_net.py

Loading...

test/functional/rpc_preciousblock.py

Loading...

test/functional/rpc_rawtransaction.py

Loading...

test/functional/rpc_setban.py

Loading...

test/functional/wallet_abandonconflict.py

Loading...

test/functional/wallet_address_types.py

Loading...

test/functional/wallet_avoidreuse.py

Loading...

test/functional/wallet_backup.py

Loading...

test/functional/wallet_balance.py

Loading...

test/functional/wallet_basic.py

Loading...

test/functional/wallet_hd.py

Loading...

test/functional/wallet_import_rescan.py

Loading...

test/functional/wallet_keypool_topup.py

Loading...

test/functional/wallet_listsinceblock.py

Loading...

test/functional/wallet_reorgsrestore.py

Loading...

test/functional/wallet_txn_clone.py

Loading...

test/functional/wallet_txn_doublespend.py

Loading...