[Cashtab] Patch for @generated script on osx
AbandonedPublic
Actions

Authored by kieran709 on Dec 2 2021, 15:35.

Details

Reviewers

bytesofman
hungsam
Fabien

Group Reviewers

Restricted Project

Summary

Attempting to fix an issue with the addGenerated script not running on OSX, however I cannot test as I do not have a mac.

Because BSD find requires a path and GNU find doesn't, the idea is that adding a ' . ' in the find logic will tell the terminal to search the current directory. Revised script appears to work on Linux, however I have no way of testing on a Mac. Related to task T2030.

Test Plan

on a Mac:
cd web/cashtab
run ./scripts/addGenerated
ensure there are no illegal option errors.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

addGenerated-osx-patch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17512
Build 34850: Build Diff	cashtab-tests
Build 34849: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 2 2021, 15:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2021, 15:35

kieran709 requested review of this revision.Dec 2 2021, 15:35

kieran709 edited the summary of this revision. (Show Details)Dec 2 2021, 15:36

Harbormaster completed remote builds in B17512: Diff 31233.Dec 2 2021, 15:38

kieran709 edited the summary of this revision. (Show Details)Dec 2 2021, 18:30

kieran709 added a reviewer: hungsam.

getting "invalid command code ."

Screen Shot 2021-12-03 at 11.06.13 am.png (422×1 px, 126 KB)

There are a lot of issues in this script, it's incredible this passed the linter, I need to check why this is the case.

This revision now requires changes to proceed.Dec 3 2021, 21:45

So the linter didn't run because the script itself is marked as generated. I made a pass on it in D10629, which I tested on OSX.
@hungsam do you mind trying that version and confirm it works on your machine ?