Using the same logic as TokenListItem, eToken icon added to send page. Related to task T1988.
Custom Token:
Generated Token:
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC08eca63147ed: [Cashtab] Added eToken icon to send page
cd web/cashtab
npm start
navigate to eTokens tab
select a token with a custom icon
ensure icon displays at top of token table
navigate back to eTokens tab
select a token with a generated icon
ensure icon displays at top of token table
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- display-icon-on-etoken-page
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 17624 Build 35074: Build Diff cashtab-tests Build 35073: arc lint + arc unit
Event Timeline
Comment Actions
The cropping of the icon is fairly noticeable when testing on mobile devices with no ability to scroll to see the full image.
- Can you play around with auto sizing the table width to a percentage of the screen? The icon may need to be dynamically sized within the width of the table row, so ideally a % as well.
- Alternatively restrict it to a small size but give users the ability to hover/click on it and view the full icon in an ant design popover
- Was also going to suggest invisible scrollbars but it doesn't fix the initial jarring visual of the crop.
Comment Actions
Reverted custom icon back to 32x32 on token info page. Added popover to image, on click a 256x256 image will appear. Background color on tooltip set to transparent, although the area around the picture is slightly lighter than the rest of the page. Attempted in various ways to remove the black arrow from the tooltip but haven't been successful.
