Page MenuHomePhabricator

[Cashtab] Clear amount & address fields on send
ClosedPublic

Authored by kieran709 on Dec 10 2021, 20:55.

Details

Reviewers
bytesofman
emack
Group Reviewers
Restricted Project
Commits
rABCe2504290d452: [Cashtab] Clear amount & address fields on send
Summary

Added a user submitted function which clears the address and amount fields when the send button is clicked. Appears to work when sending XEC, sending a message, or replying to a message. Related to task T2075.

Test Plan

cd web/cashtab && npm start
navigate to send tab
send XEC
from another wallet:
send a message
from local wallet:
reply to message

ensure transactions go through and that the address and amount fields are cleared on click

Diff Detail

Repository
rABC Bitcoin ABC
Branch
clear-form-on-send
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17622
Build 35070: Build Diffcashtab-tests
Build 35069: arc lint + arc unit

Event Timeline

emack requested changes to this revision.Dec 11 2021, 00:36
emack added a subscriber: emack.

Proposed change tested all ok across chrome, firefox and extension plugin. However the OP_RETURN message still persists, can you clear the 'opReturnMsg' <TextArea> (line 793) as part of this post-send behavior so it's consistent across screen?

This revision now requires changes to proceed.Dec 11 2021, 00:36

Instead of clearing the form onClick, I've added a function which clears the form following the success notification (sendXecNotification), added opReturnMsg param to the default formData object's state.

first level review is green

This revision is now accepted and ready to land.Dec 14 2021, 22:28