Page MenuHomePhabricator
Differential D10705

[Cashtab] Add note to alert users to OP_RETURN msg visibility.
ClosedPublic
Actions

Authored by kieran709 on Dec 20 2021, 22:10.

Details

Reviewers
emack
bytesofman
Group Reviewers
Restricted Project
Commits
rABCff71713eb4ef: [Cashtab] Add note to alert users to OP_RETURN msg visibility.
Summary

Added alert to inform users that Cashtab messages are visible on the blockchain. Related to task T2103

Test Plan

cd web/cashtab && npm start
navigate to send tab and click advanced dropdown
ensure that the alert appears and that messaging is correct.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
op-msg-alert
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17698
Build 35222: Build Diffcashtab-tests
Build 35221: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 20 2021, 22:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 20 2021, 22:10
kieran709 requested review of this revision.Dec 20 2021, 22:10
Harbormaster completed remote builds in B17696: Diff 31486.Dec 20 2021, 22:13
bytesofman requested changes to this revision.Dec 20 2021, 22:28
bytesofman added inline comments.
web/cashtab/src/components/Send/Send.js
788 ↗(On Diff #31486)

description="Messages are public"

This revision now requires changes to proceed.Dec 20 2021, 22:28
kieran709 updated this revision to Diff 31488.Dec 20 2021, 22:33

Updated alert message.

Harbormaster completed remote builds in B17698: Diff 31488.Dec 20 2021, 22:36
bytesofman accepted this revision.Dec 20 2021, 23:07
This revision is now accepted and ready to land.Dec 20 2021, 23:07
Closed by commit rABCff71713eb4ef: [Cashtab] Add note to alert users to OP_RETURN msg visibility. (authored by kieran709). · Explain WhyDec 20 2021, 23:20
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABCff71713eb4ef: [Cashtab] Add note to alert users to OP_RETURN msg visibility..

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
6 lines

Diff 31488

View Options

web/cashtab/src/components/Send/Send.js

Loading...