Page MenuHomePhabricator
Differential D1071

[Part2] Use config.GetChainParams() insted of Params() where config is abailable in local scope
ClosedPublic
Actions

Authored by matra774 on Feb 9 2018, 10:35.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Maniphest Tasks
T170: Replace direct calls of Params() with Config.GetChainParams()
Commits
rSTAGING90c710fa0b58: [Part2] Use config.GetChainParams() insted of Params() where config is…
rABC90c710fa0b58: [Part2] Use config.GetChainParams() insted of Params() where config is…
Summary

Replace direct calls of Params() with Config.GetChainParams() Refs T170

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
T170-D1071
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1881
Build 1922: Bitcoin ABC Buildbot (legacy)
Build 1921: arc lint + arc unit

Event Timeline

matra774 created this revision.Feb 9 2018, 10:35
Owners added a reviewer: Restricted Owners Package.Feb 9 2018, 10:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2018, 10:35
teamcity added a subscriber: teamcity.Feb 9 2018, 21:30

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B1811: Diff 2824.Feb 9 2018, 21:51
teamcity added a comment.Feb 9 2018, 21:51

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

jasonbcox accepted this revision.Feb 10 2018, 00:18
This revision is now accepted and ready to land.Feb 10 2018, 00:18
matra774 updated this revision to Diff 2905.Feb 16 2018, 21:37

Updating already accepted revision D1071, becaue it has file mode changes

teamcity added a comment.Feb 16 2018, 21:39

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

matra774 updated this revision to Diff 2906.Feb 16 2018, 21:47

Part2 - updating Diff, so that it now contais both commits for this task

teamcity added a comment.Feb 16 2018, 21:49

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 16 2018, 21:58

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1881: Diff 2905.Feb 16 2018, 21:58
Harbormaster completed remote builds in B1882: Diff 2906.Feb 16 2018, 22:08
teamcity added a comment.Feb 16 2018, 22:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

matra774 updated this revision to Diff 2908.Feb 16 2018, 23:16

Rebased to fix permissions on files, that I have modified
I also removed executable flag from src/secp256k1/src/modules/recovery/main_impl.h (I have checked old versions and this flag is already present on master)

teamcity added a comment.Feb 16 2018, 23:18

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 16 2018, 23:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1883: Diff 2908.Feb 16 2018, 23:38
jasonbcox accepted this revision.Feb 18 2018, 01:12
Closed by commit rABC90c710fa0b58: [Part2] Use config.GetChainParams() insted of Params() where config is… (authored by matra774). · Explain WhyFeb 18 2018, 09:09
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2905

View Options

src/addrdb.h

Loading...
View Options

src/addrdb.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/secp256k1/src/modules/recovery/main_impl.h

Loading...
View Options

src/test/net_tests.cpp

Loading...