Page MenuHomePhabricator
Create Task
Maniphest T170

Replace direct calls of Params() with Config.GetChainParams()
Open, Needs TriagePublic
Actions

Description

Direct calls to Params() should be replaced with config.GetChainParams() where appropriate.

Revisions and Commits

rSTAGING Bitcoin ABC staging
D1080rSTAGING0162ab0879f8 [Part6] Removed the single parameter overload of static function…
D1079rSTAGINGa9e4406060a1 [Part5] CWallet constructor now has additional parameter chainParams
D1073rSTAGING5d31b1c35d94 Replaced calls to DecodeDestination(str) with DecodeDestination(str,config)…
AuditedD1071rSTAGING90c710fa0b58 [Part2] Use config.GetChainParams() insted of Params() where config is…
AuditedD1070rSTAGING5242be937fdb [Part1] Removed Params() from addrdb

Related Objects

Event Timeline

jasonbcox created this task.Jan 19 2018, 20:04
matra774 added a revision: D1070: [Part1] Removed Params() from addrdb.Feb 8 2018, 21:17
matra774 mentioned this in D1070: [Part1] Removed Params() from addrdb.Feb 8 2018, 21:21
matra774 added a revision: D1071: [Part2] Use config.GetChainParams() insted of Params() where config is abailable in local scope.Feb 9 2018, 10:35
matra774 added a revision: D1073: Replaced calls to DecodeDestination(str) with DecodeDestination(str,config) where config was already available in local scope.Feb 9 2018, 12:57
matra774 added a revision: D1079: [Part5] CWallet constructor now has additional parameter chainParams.Feb 10 2018, 09:24
matra774 added a revision: D1080: [Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams..Feb 11 2018, 17:04
matra774 added a subscriber: matra774.Feb 13 2018, 20:32

@jasonbcox, should I also try to remove the following functions from DstEncode.h:

// Temporary workaround. Don't rely on global state, pass all parameters in new
// code.

std::string EncodeDestination(const CTxDestination &);
CTxDestination DecodeDestination(const std::string &addr);
bool IsValidDestinationString(const std::string &addr);

BTW: EncodeDestination requires Config, because of support of new bitcoincash address support (config.UseCashAddrEncoding()).

schancel updated the task description. (Show Details)Feb 16 2018, 05:47
KONTRABANDA added a subscriber: KONTRABANDA.Feb 18 2018, 06:41
matra774 added a commit: rSTAGING5242be937fdb: [Part1] Removed Params() from addrdb.Mar 1 2018, 23:48
matra774 added a commit: rSTAGING90c710fa0b58: [Part2] Use config.GetChainParams() insted of Params() where config is….
matra774 added a commit: rSTAGING5d31b1c35d94: Replaced calls to DecodeDestination(str) with DecodeDestination(str,config)….
matra774 added a commit: rSTAGINGa9e4406060a1: [Part5] CWallet constructor now has additional parameter chainParams.
matra774 added a commit: rSTAGING0162ab0879f8: [Part6] Removed the single parameter overload of static function….
KONTRABANDA added a comment.Mar 4 2018, 04:08
This comment was removed by deadalnix.
KONTRABANDA awarded a token.Mar 4 2018, 04:09
deadalnix added a subscriber: deadalnix.Mar 4 2018, 08:41