Page MenuHomePhabricator

Replace direct calls of Params() with Config.GetChainParams()
Open, Needs TriagePublic

Description

Direct calls to Params() should be replaced with config.GetChainParams() where appropriate.

Details

Commits
D1080 / Restricted Diffusion Commit
D1079 / Restricted Diffusion Commit
D1073 / Restricted Diffusion Commit
D1071 / Restricted Diffusion Commit
D1070 / Restricted Diffusion Commit

Event Timeline

jasonbcox created this task.Jan 19 2018, 20:04

@jasonbcox, should I also try to remove the following functions from DstEncode.h:

// Temporary workaround. Don't rely on global state, pass all parameters in new
// code.

std::string EncodeDestination(const CTxDestination &);
CTxDestination DecodeDestination(const std::string &addr);
bool IsValidDestinationString(const std::string &addr);

BTW: EncodeDestination requires Config, because of support of new bitcoincash address support (config.UseCashAddrEncoding()).

schancel updated the task description. (Show Details)Feb 16 2018, 05:47
matra774 added a commit: Restricted Diffusion Commit.Mar 1 2018, 23:48
matra774 added a commit: Restricted Diffusion Commit.
matra774 added a commit: Restricted Diffusion Commit.
matra774 added a commit: Restricted Diffusion Commit.
matra774 added a commit: Restricted Diffusion Commit.
This comment was removed by deadalnix.