Page MenuHomePhabricator

matra774 (Matej)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 6 2018, 15:00 (84 w, 1 d)

Recent Activity

Mar 6 2018

matra774 committed rABC2d8bfe4d0dba: Search the filesystem to discover tests. Use the timing info from build and src… (authored by matra774).
Search the filesystem to discover tests. Use the timing info from build and src…
Mar 6 2018, 19:13
matra774 closed D1135: Search the filesystem to discover tests. Use the timing info from build and src directory to chose which ones are extended tests and which are regular ones.
Mar 6 2018, 19:12
matra774 updated the diff for D1135: Search the filesystem to discover tests. Use the timing info from build and src directory to chose which ones are extended tests and which are regular ones.

Rebased on master to resolve merge conflicts (some tests were added to TEST_LIST, which is being deleted bz this DIFF)
I've also re-run all tests to get updated timing.json, which now includes the new tests.

Mar 6 2018, 15:34

Mar 4 2018

matra774 added inline comments to D1135: Search the filesystem to discover tests. Use the timing info from build and src directory to chose which ones are extended tests and which are regular ones.
Mar 4 2018, 20:58

Mar 3 2018

matra774 placed T239: Provide callgraphs for the Bitcoin-ABC Codebase up for grabs.
Mar 3 2018, 15:52
matra774 added a comment to T239: Provide callgraphs for the Bitcoin-ABC Codebase.

I've done some preliminary analysis on call graph generations and I'm shraing the results here.
Unfortunately I did not have enough time to actually analyze bitocin-abc code and find the low hanging fruit, that task description mentions.
Still' I hope, that's a good start.

Mar 3 2018, 15:51

Mar 2 2018

matra774 updated the diff for D1135: Search the filesystem to discover tests. Use the timing info from build and src directory to chose which ones are extended tests and which are regular ones.

Fix according to review comments

Mar 2 2018, 15:53

Feb 26 2018

matra774 claimed T163: test_runner.py should not list all the test, but instead be able to find them..
Feb 26 2018, 21:21 · Bootcamp

Feb 25 2018

matra774 committed rABC3790258ce49a: Write test timing information to the build tree when running test_runner.py (authored by matra774).
Write test timing information to the build tree when running test_runner.py
Feb 25 2018, 19:07
matra774 closed D1116: Write test timing information to the build tree when running test_runner.py.
Feb 25 2018, 19:07
Herald added a reviewer for D1135: Search the filesystem to discover tests. Use the timing info from build and src directory to chose which ones are extended tests and which are regular ones: Restricted Project.
Feb 25 2018, 17:22
matra774 added a revision to T163: test_runner.py should not list all the test, but instead be able to find them.: D1135: Search the filesystem to discover tests. Use the timing info from build and src directory to chose which ones are extended tests and which are regular ones.
Feb 25 2018, 17:22 · Bootcamp
matra774 updated the diff for D1116: Write test timing information to the build tree when running test_runner.py.

Minor fix: Renamed Timings.build_dir to dir

Feb 25 2018, 14:30
matra774 updated the test plan for D1116: Write test timing information to the build tree when running test_runner.py.
Feb 25 2018, 11:24
matra774 updated the diff for D1116: Write test timing information to the build tree when running test_runner.py.

Splitting this update in smaller commits. This commit saves test timing in build_dir/timing.json

Feb 25 2018, 11:11

Feb 24 2018

matra774 claimed T239: Provide callgraphs for the Bitcoin-ABC Codebase.
Feb 24 2018, 20:16
matra774 added a comment to T239: Provide callgraphs for the Bitcoin-ABC Codebase.

I'll try to work on this...

Feb 24 2018, 20:09

Feb 23 2018

matra774 added inline comments to D1116: Write test timing information to the build tree when running test_runner.py.
Feb 23 2018, 08:58

Feb 22 2018

matra774 added inline comments to D1116: Write test timing information to the build tree when running test_runner.py.
Feb 22 2018, 06:48

Feb 21 2018

Herald added a reviewer for D1116: Write test timing information to the build tree when running test_runner.py: Restricted Project.
Feb 21 2018, 22:09
matra774 added a revision to T163: test_runner.py should not list all the test, but instead be able to find them.: D1116: Write test timing information to the build tree when running test_runner.py.
Feb 21 2018, 22:09 · Bootcamp

Feb 19 2018

matra774 committed rABC66843371c2fd: T164 - Implement junit output support in test_runner.py (authored by matra774).
T164 - Implement junit output support in test_runner.py
Feb 19 2018, 22:02
matra774 closed D1089: T164 - Implement junit output support in test_runner.py.
Feb 19 2018, 22:02
matra774 added inline comments to D1089: T164 - Implement junit output support in test_runner.py.
Feb 19 2018, 22:00
matra774 committed rABC0162ab0879f8: [Part6] Removed the single parameter overload of static function… (authored by matra774).
[Part6] Removed the single parameter overload of static function…
Feb 19 2018, 09:20
matra774 closed D1080: [Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams..
Feb 19 2018, 09:20

Feb 18 2018

matra774 added a comment to T163: test_runner.py should not list all the test, but instead be able to find them..

Is it OK to store timing.json in git (test/function/timing.json)?

Feb 18 2018, 21:12 · Bootcamp
matra774 added a comment to D1089: T164 - Implement junit output support in test_runner.py.

and it looks like you may need to run autopep8 on the file.

autopep8 was already run before the first commit. It looks like arc diff also runs arc lint. Unitl I've installed autopep8 or arc diff kept failing.

Feb 18 2018, 20:22
matra774 updated the diff for D1080: [Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams..

Rebased onto master

Feb 18 2018, 20:19
matra774 committed rABCa9e4406060a1: [Part5] CWallet constructor now has additional parameter chainParams (authored by matra774).
[Part5] CWallet constructor now has additional parameter chainParams
Feb 18 2018, 19:53
matra774 closed D1079: [Part5] CWallet constructor now has additional parameter chainParams.
Feb 18 2018, 19:53
matra774 updated the diff for D1089: T164 - Implement junit output support in test_runner.py.

Addressed review

Feb 18 2018, 18:19
matra774 added a comment to T206: Refactor script_tests.cpp::PushSig() to have default SigHashType param.

Hmm, PushSig already has default SigHashType parameter (introduced in D932):

Feb 18 2018, 13:42 · Bootcamp
matra774 updated the diff for D1079: [Part5] CWallet constructor now has additional parameter chainParams.

Rebasing onto master to avoid conflicts

Feb 18 2018, 10:24
matra774 committed rABC5d31b1c35d94: Replaced calls to DecodeDestination(str) with DecodeDestination(str,config)… (authored by matra774).
Replaced calls to DecodeDestination(str) with DecodeDestination(str,config)…
Feb 18 2018, 09:18
matra774 closed D1073: Replaced calls to DecodeDestination(str) with DecodeDestination(str,config) where config was already available in local scope.
Feb 18 2018, 09:18
matra774 committed rABC90c710fa0b58: [Part2] Use config.GetChainParams() insted of Params() where config is… (authored by matra774).
[Part2] Use config.GetChainParams() insted of Params() where config is…
Feb 18 2018, 09:10
matra774 closed D1071: [Part2] Use config.GetChainParams() insted of Params() where config is abailable in local scope.
Feb 18 2018, 09:09
matra774 committed rABC10ec91661ec5: Make CTransaction construction from CMutableTransaction explicit (authored by matra774).
Make CTransaction construction from CMutableTransaction explicit
Feb 18 2018, 00:08
matra774 closed D1106: Make CTransaction construction from CMutableTransaction explicit.
Feb 18 2018, 00:07

Feb 17 2018

matra774 updated the diff for D1106: Make CTransaction construction from CMutableTransaction explicit.

Rebasing again after doing git fetch origin master

Feb 17 2018, 23:45
matra774 updated the diff for D1106: Make CTransaction construction from CMutableTransaction explicit.

Rebasing on master (arc land failed)

Feb 17 2018, 12:05
matra774 updated the diff for D1106: Make CTransaction construction from CMutableTransaction explicit.

Addressed review comments

Feb 17 2018, 10:38

Feb 16 2018

matra774 added a comment to T241: Fix recommended workflow documentation.

Here are some guidelines on how to get out of the mess, created by stacking and rebasing commits.

  • Some of your commits might be detached (as a result of wrong rebase). To find them use git log --graph --decorate --pretty=oneline $(git rev-list -g --all --author=yourName)
  • Match those commits with Phabricator Diffs by visiting https://reviews.bitcoinabc.org/Dxxxx and checking hashes in Revision Contents/Commits
  • One you found detached commit, create a branch from it: git branch yourBranchName commitHash
  • Someone else might have already pushed his commits onto master. To avoid problems with landing your commits, fetch remote master changes by doing git fetch origin master && git rebase -i origin/master
  • Rebase your branch: on master: git rebase master -i
  • Make and necessary changes and commit them
  • To check if arc still maintain reference to the Diff, run: arc which
  • Arc probably lost the reference to your Diff. It also sometimes mixes up what was already commited and what not. To specify Diff and commit range, use Use arc diff --update Dxxx firstCommitHash
Feb 16 2018, 23:37
matra774 updated the diff for D1071: [Part2] Use config.GetChainParams() insted of Params() where config is abailable in local scope.

Rebased to fix permissions on files, that I have modified
I also removed executable flag from src/secp256k1/src/modules/recovery/main_impl.h (I have checked old versions and this flag is already present on master)

Feb 16 2018, 23:16
matra774 committed rABC5242be937fdb: [Part1] Removed Params() from addrdb (authored by matra774).
[Part1] Removed Params() from addrdb
Feb 16 2018, 22:03
matra774 closed D1070: [Part1] Removed Params() from addrdb.
Feb 16 2018, 22:02
matra774 updated the diff for D1071: [Part2] Use config.GetChainParams() insted of Params() where config is abailable in local scope.

Part2 - updating Diff, so that it now contais both commits for this task

Feb 16 2018, 21:47
matra774 updated the diff for D1071: [Part2] Use config.GetChainParams() insted of Params() where config is abailable in local scope.

Updating already accepted revision D1071, becaue it has file mode changes

Feb 16 2018, 21:37
matra774 updated the diff for D1073: Replaced calls to DecodeDestination(str) with DecodeDestination(str,config) where config was already available in local scope.

Trying to fix permission (part 4)

Feb 16 2018, 07:47
matra774 updated the diff for D1080: [Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams..

Trying to fix the permission (again)

Feb 16 2018, 07:40
Herald added a reviewer for D1106: Make CTransaction construction from CMutableTransaction explicit: Restricted Project.
Feb 16 2018, 02:51
matra774 added a revision to T238: Make CTransaction construction from CMutableTransaction explicit: D1106: Make CTransaction construction from CMutableTransaction explicit.
Feb 16 2018, 02:51 · Bootcamp

Feb 15 2018

matra774 added a comment to D1089: T164 - Implement junit output support in test_runner.py.

You are my hero. I'll review this ASAP. A quick passover though:

Feb 15 2018, 16:02

Feb 13 2018

matra774 added a comment to T170: Replace direct calls of Params() with Config.GetChainParams().

@jasonbcox, should I also try to remove the following functions from DstEncode.h:

Feb 13 2018, 20:32 · Bootcamp
matra774 added a comment to T128: Add Junit output support to rpc tests.

@schancel, how is this task different from T164?

Feb 13 2018, 13:55
matra774 updated the summary of D1089: T164 - Implement junit output support in test_runner.py.
Feb 13 2018, 13:54
matra774 updated the summary of D1089: T164 - Implement junit output support in test_runner.py.
Feb 13 2018, 13:54
Herald added a reviewer for D1089: T164 - Implement junit output support in test_runner.py: Restricted Project.
Feb 13 2018, 12:49
matra774 added a revision to T164: Implement junit output support in test_runner.py: D1089: T164 - Implement junit output support in test_runner.py.
Feb 13 2018, 12:49 · Bootcamp
matra774 requested review of D1073: Replaced calls to DecodeDestination(str) with DecodeDestination(str,config) where config was already available in local scope.

It doesn't looks like this is fixed.

Feb 13 2018, 09:37

Feb 11 2018

matra774 updated the diff for D1080: [Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams..

fixed executable flag permission (again :-())

Feb 11 2018, 21:21
Herald added a reviewer for D1080: [Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams.: Restricted Project.
Feb 11 2018, 17:04
matra774 added a revision to T170: Replace direct calls of Params() with Config.GetChainParams(): D1080: [Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams..
Feb 11 2018, 17:04 · Bootcamp
matra774 updated the diff for D1079: [Part5] CWallet constructor now has additional parameter chainParams.

fixed 2 of 3 review comments. The locking question remains open

Feb 11 2018, 13:59
matra774 added inline comments to D1079: [Part5] CWallet constructor now has additional parameter chainParams.
Feb 11 2018, 09:56

Feb 10 2018

matra774 updated the diff for D1073: Replaced calls to DecodeDestination(str) with DecodeDestination(str,config) where config was already available in local scope.

Fixed permissions (also on files src/rpc/mining.cpp, rpc/rpc/misc.cpp, whose permissions was not modified by original commit)

Feb 10 2018, 11:09
matra774 updated the diff for D1070: [Part1] Removed Params() from addrdb.

Fixed file permissions

Feb 10 2018, 10:56
Herald added a reviewer for D1079: [Part5] CWallet constructor now has additional parameter chainParams: Restricted Project.
Feb 10 2018, 09:24
matra774 added a revision to T170: Replace direct calls of Params() with Config.GetChainParams(): D1079: [Part5] CWallet constructor now has additional parameter chainParams.
Feb 10 2018, 09:24 · Bootcamp

Feb 9 2018

Herald added a reviewer for D1073: Replaced calls to DecodeDestination(str) with DecodeDestination(str,config) where config was already available in local scope: Restricted Project.
Feb 9 2018, 21:05
matra774 added a revision to T170: Replace direct calls of Params() with Config.GetChainParams(): D1073: Replaced calls to DecodeDestination(str) with DecodeDestination(str,config) where config was already available in local scope.
Feb 9 2018, 21:05 · Bootcamp
Herald added a reviewer for D1071: [Part2] Use config.GetChainParams() insted of Params() where config is abailable in local scope: Restricted Project.
Feb 9 2018, 21:05
matra774 added a revision to T170: Replace direct calls of Params() with Config.GetChainParams(): D1071: [Part2] Use config.GetChainParams() insted of Params() where config is abailable in local scope.
Feb 9 2018, 21:05 · Bootcamp

Feb 8 2018

matra774 added a comment to D1070: [Part1] Removed Params() from addrdb.

Here is the first chunk of T170 – I replaced usages of Params() in addrdb.cpp and fixed all refrences.

Feb 8 2018, 21:21
Herald added a reviewer for D1070: [Part1] Removed Params() from addrdb: Restricted Project.
Feb 8 2018, 21:17
matra774 added a revision to T170: Replace direct calls of Params() with Config.GetChainParams(): D1070: [Part1] Removed Params() from addrdb.
Feb 8 2018, 21:17 · Bootcamp