Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Maniphest Tasks

T170: Replace direct calls of Params() with Config.GetChainParams()

Commits

rSTAGING0162ab0879f8: [Part6] Removed the single parameter overload of static function…
rABC0162ab0879f8: [Part6] Removed the single parameter overload of static function…

Summary

All uses of DecodeDestination that provided only one parameter where replaced with another overload, that explicitly takes chainParams.
The single parameter overload of DecodeDestination was removed, since it should not be used.
Note, that there are still two other single parameter functions, which should be fixed two (EncodeDestination, IsValidDestinationString)

Refs T170

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

matra774 created this revision.Feb 11 2018, 17:04

Owners added a reviewer: Restricted Owners Package.Feb 11 2018, 17:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 11 2018, 17:04

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1827: Diff 2843.Feb 11 2018, 17:27

Every file you're touching is becoming executable. Please fix.

This revision now requires changes to proceed.Feb 11 2018, 18:28

fixed executable flag permission (again :-())

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B1829: Diff 2845.Feb 11 2018, 21:42

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel edited the summary of this revision. (Show Details)Feb 16 2018, 05:42

schancel edited the test plan for this revision. (Show Details)

Trying to fix the permission (again)

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B1871: Diff 2895!Feb 16 2018, 08:02

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Rebased onto master

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B1889: Diff 2921.Feb 18 2018, 20:39

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

LGTM

This revision is now accepted and ready to land.Feb 18 2018, 20:53

Closed by commit rABC0162ab0879f8: [Part6] Removed the single parameter overload of static function… (authored by matra774). · Explain WhyFeb 19 2018, 09:20

This revision was automatically updated to reflect the committed changes.

[Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 2925

src/bitcoin-tx.cpp

src/dstencode.h

src/qt/guiutil.h

src/qt/guiutil.cpp

src/qt/sendcoinsdialog.cpp

src/qt/sendcoinsentry.cpp

src/qt/signverifymessagedialog.cpp

src/qt/walletmodel.h

src/qt/walletmodel.cpp

src/test/key_tests.cpp

[Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2925

src/bitcoin-tx.cpp

src/dstencode.h

src/qt/guiutil.h

src/qt/guiutil.cpp

src/qt/sendcoinsdialog.cpp

src/qt/sendcoinsentry.cpp

src/qt/signverifymessagedialog.cpp

src/qt/walletmodel.h

src/qt/walletmodel.cpp

src/test/key_tests.cpp

[Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams.
ClosedPublic
Actions

Revision Contents
Changeset List