Page MenuHomePhabricator

[Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams.
ClosedPublic

Authored by matra774 on Feb 11 2018, 17:04.

Details

Summary

All uses of DecodeDestination that provided only one parameter where replaced with another overload, that explicitly takes chainParams.
The single parameter overload of DecodeDestination was removed, since it should not be used.
Note, that there are still two other single parameter functions, which should be fixed two (EncodeDestination, IsValidDestinationString)

Refs T170

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Feb 11 2018, 17:04
jasonbcox requested changes to this revision.Feb 11 2018, 18:28

Every file you're touching is becoming executable. Please fix.

This revision now requires changes to proceed.Feb 11 2018, 18:28

fixed executable flag permission (again :-())

schancel edited the test plan for this revision. (Show Details)

Trying to fix the permission (again)

This revision is now accepted and ready to land.Feb 18 2018, 20:53
This revision was automatically updated to reflect the committed changes.