[Part6] Removed the single parameter overload of static function DecodeDestination. WalletModel now provides access to chainParams.
Summary:
All uses of DecodeDestination that provided only one parameter where replaced with another overload, that explicitly takes chainParams.
The single parameter overload of DecodeDestination was removed, since it should not be used.
Note, that there are still two other single parameter functions, which should be fixed two (EncodeDestination, IsValidDestinationString)
Refs T170
Test Plan:
make check ./test/functional/test_runner.py --extended
Reviewers: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc
Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc
Subscribers: teamcity
Maniphest Tasks: T170
Differential Revision: https://reviews.bitcoinabc.org/D1080