Differential D10747

[Cashtab] Increase Transaction History to 10 transactions
ClosedPublic
Actions

Authored by emack on Dec 31 2021, 04:38.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC7617f55d6116: [Cashtab] Increase Transaction History to 10 transactions

Summary

Prompted by Alita on Telegram, the current 5 transaction history is a bit limited given we've now released public and private messaging functionalities.

A full refactor to structurally improve the cashtab transaction history retrieval logic will take some time, given the need to evaluate the chronik client, so this diff is an interim adjustment to increase the tx history from 5 to 10 transactions.

Tested across:

Browsers: Chrome, Firefox, Brave
Mobile: iOS and Android
Plugin: Cashtab Extension

No rate limit issues encountered.

Test Plan

npm start
open a wallet with more than 10 transactions, wait for history update, if not send some XEC to trigger the update. Verify exactly 10 transactions are displayed
open a wallet with less than 10 transactions, ensure the exact number of transactions is displayed.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

txhistoryincrease

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17767
Build 35360: Build Diff	cashtab-tests
Build 35359: arc lint + arc unit

Event Timeline

emack created this revision.Dec 31 2021, 04:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 31 2021, 04:38

emack requested review of this revision.Dec 31 2021, 04:38

Harbormaster completed remote builds in B17767: Diff 31595.Dec 31 2021, 04:41

emack mentioned this in T1713: Paginated transaction history.Dec 31 2021, 05:17

Good point + diff.

A full refactor to structurally improve the cashtab transaction history retrieval logic will take some time, given the need to evaluate the chronik client, so this diff is an interim adjustment to increase the tx history from 5 to 10 transactions.

We already have some optimizations in place to fetch the tx history, so I don't think we need to wait for chronik implementation to add things like pagination and local storage of tx + first seen timestamp.

This revision is now accepted and ready to land.Jan 3 2022, 13:38

Closed by commit rABC7617f55d6116: [Cashtab] Increase Transaction History to 10 transactions (authored by emack). · Explain WhyJan 4 2022, 07:12

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC7617f55d6116: [Cashtab] Increase Transaction History to 10 transactions.