Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC5257d17bbda2: Move StripRedundantLastElementsOfPath before ArgsManager class.

Summary

PR description:

This PR attempts to contribute to "Remove gArgs" (#21005).

Main changes:
`GetDataDir()` function is moved to `ArgsManager.GetDataDirPath()`.
`GetBlocksDir()` function is moved to `ArgsManager.GetBlocksDirPath()`.

This is a backport of core#21244 [1/8]
https://github.com/bitcoin/bitcoin/pull/21244/commits/70cdf679f8e665dbdc3301873a0267fe9faa72cd

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 3 2022, 16:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 3 2022, 16:20

PiRK requested review of this revision.Jan 3 2022, 16:20

teamcity edited the summary of this revision. (Show Details)Jan 3 2022, 16:20

PiRK added a child revision: D10750: Move GetDataDir(fNetSpecific) implementation to ArgsManager..Jan 3 2022, 16:22

PiRK edited the summary of this revision. (Show Details)Jan 3 2022, 16:23

Harbormaster completed remote builds in B17773: Diff 31606.Jan 3 2022, 16:37

Fabien accepted this revision.Jan 3 2022, 20:07

This revision is now accepted and ready to land.Jan 3 2022, 20:07

Closed by commit rABC5257d17bbda2: Move StripRedundantLastElementsOfPath before ArgsManager class. (authored by Kiminuo <kiminuo@protonmail.com>, committed by PiRK). · Explain WhyJan 4 2022, 14:27

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5257d17bbda2: Move StripRedundantLastElementsOfPath before ArgsManager class..

Move StripRedundantLastElementsOfPath before ArgsManager class.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31627

src/util/system.cpp

Move StripRedundantLastElementsOfPath before ArgsManager class.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31627

src/util/system.cpp

Move StripRedundantLastElementsOfPath before ArgsManager class.
ClosedPublic
Actions

Revision Contents
Changeset List