Page MenuHomePhabricator
Differential D10752

BasicTestingSetup: Add ArgsManager.
ClosedPublic
Actions

Authored by PiRK on Jan 3 2022, 16:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa0d297603373: BasicTestingSetup: Add ArgsManager.
Summary

This is a backport of core#21244 [5/8]
https://github.com/bitcoin/bitcoin/pull/21244/commits/511ce3a26b3b78e14acd0d85496b5422a236cf63

Depends on D10753

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 3 2022, 16:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 3 2022, 16:27
PiRK requested review of this revision.Jan 3 2022, 16:27
teamcity edited the summary of this revision. (Show Details)Jan 3 2022, 16:28
PiRK added a child revision: D10753: scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp.Jan 3 2022, 16:28
Harbormaster completed remote builds in B17776: Diff 31609.Jan 3 2022, 16:45
teamcity added a comment.Jan 3 2022, 16:45
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[171/457] Automatic MOC for target bitcoin-qt-base
[172/455] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_crypto_tests.cpp.o
[173/455] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.021s

OK
[174/455] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[175/455] Automatic MOC for target test_bitcoin-qt
[176/455] Test Bitcoin utilities...
[177/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[178/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[179/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[180/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[181/455] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/ismine_tests.cpp.o
[182/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[183/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[184/455] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/scriptpubkeyman_tests.cpp.o
[185/455] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
[186/455] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o
[187/455] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o
[188/455] pow: testing aserti32d_tests
[189/455] Running utility command for check-pow-aserti32d_tests
[190/455] Running pow test suite
PASSED: pow test suite
[191/455] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/message_writer_tests.cpp.o
[192/455] Linking CXX executable src/seeder/test/test-seeder
[193/455] seeder: testing message_writer_tests
[194/455] seeder: testing p2p_messaging_tests
[195/455] Running utility command for check-seeder-message_writer_tests
[196/455] Running utility command for check-seeder-p2p_messaging_tests
[197/455] seeder: testing write_name_tests
[198/455] Running utility command for check-seeder-write_name_tests
[199/455] seeder: testing parse_name_tests
[200/455] Running utility command for check-seeder-parse_name_tests
[201/455] Running seeder test suite
PASSED: seeder test suite
[202/455] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o
[203/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[204/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[205/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[206/455] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[207/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[208/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[209/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[210/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[211/455] Linking CXX executable src/qt/test/test_bitcoin-qt
[212/455] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o
[213/455] bitcoin-qt: testing test_bitcoin-qt
[214/455] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[215/455] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
Fabien requested changes to this revision.Jan 3 2022, 20:38
Fabien added a subscriber: Fabien.

back on your queue

This revision now requires changes to proceed.Jan 3 2022, 20:38
PiRK removed a parent revision: D10751: Modify "util_datadir" unit test to not use gArgs..Jan 4 2022, 07:45
PiRK removed a child revision: D10753: scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp.
PiRK updated this revision to Diff 31620.EditedJan 4 2022, 07:47
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D10753: scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp.

rebase: move after D10753 to fix compiler warning non-static data member 'm_args' of 'LocalTestingSetup' shadows member inherited from type 'BasicTestingSetup'

PiRK added a child revision: D10755: scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs.Jan 4 2022, 07:49
Harbormaster completed remote builds in B17784: Diff 31620.Jan 4 2022, 08:08
Fabien accepted this revision.Jan 4 2022, 10:41
This revision is now accepted and ready to land.Jan 4 2022, 10:41
Closed by commit rABCa0d297603373: BasicTestingSetup: Add ArgsManager. (authored by Kiminuo <kiminuo@protonmail.com>, committed by PiRK). · Explain WhyJan 4 2022, 14:29
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa0d297603373: BasicTestingSetup: Add ArgsManager..

Revision Contents
Changeset List

PathSize
src/
test/
util/
1 line
10 lines

Diff 31630

View Options

src/test/util/setup_common.h

Loading...
View Options

src/test/util/setup_common.cpp

Loading...