Paths

Table of Contentst

Differential D10812

refactor: Extract ParseOpCode from ParseScript
ClosedPublic
Actions

Authored by PiRK on Jan 11 2022, 09:03.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb2738e030547: refactor: Extract ParseOpCode from ParseScript

Summary

Seems more natural to have mapOpNames "hidden" in ParseOpCode than in ParseScript.

A second lookup in mapOpNames is also removed.

This is a backport of core#19851

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19851

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17878
Build 35582: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 35581: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 11 2022, 09:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2022, 09:03

PiRK requested review of this revision.Jan 11 2022, 09:03

teamcity edited the summary of this revision. (Show Details)Jan 11 2022, 09:03

Harbormaster completed remote builds in B17878: Diff 31749.Jan 11 2022, 09:26

Fabien accepted this revision.Jan 11 2022, 10:30

This revision is now accepted and ready to land.Jan 11 2022, 10:30

Closed by commit rABCb2738e030547: refactor: Extract ParseOpCode from ParseScript (authored by Joo Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyJan 11 2022, 16:41

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb2738e030547: refactor: Extract ParseOpCode from ParseScript.

Revision Contents
Changeset List

Path

Size

src/

core_read.cpp

27 lines

test/

util/

data/

bitcoin-util-test.json

2 lines

Diff 31749

View Options

src/core_read.cpp