Differential D10823

Add an option to override the max addr sent in response to a getaddr message
ClosedPublic
Actions

Authored by Fabien on Jan 13 2022, 14:31.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC40ddc93c7c96: Add an option to override the max addr sent in response to a getaddr message

Summary

This will make it possible to write tests for the avalanche node addresses request and responses. Since this is intended for testing only this is put in the hidden options, there is no boundary check and the default causes no change in behavior (tested in p2p_getaddr_caching.py).

Ref T1696.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

max_getaddr_size

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17901
Build 35625: Build Diff	build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-diff · build-debug · build-clang
Build 35624: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 13 2022, 14:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2022, 14:31

Fabien requested review of this revision.Jan 13 2022, 14:31

Harbormaster completed remote builds in B17901: Diff 31794.Jan 13 2022, 14:46

PiRK accepted this revision.Jan 13 2022, 17:45

This revision is now accepted and ready to land.Jan 13 2022, 17:45

Closed by commit rABC40ddc93c7c96: Add an option to override the max addr sent in response to a getaddr message (authored by Fabien). · Explain WhyJan 13 2022, 20:16

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC40ddc93c7c96: Add an option to override the max addr sent in response to a getaddr message.

PiRK mentioned this in D10920: [net processing] Refactor MaybeSendAddr().Jan 27 2022, 16:17

PiRK mentioned this in rABC6865c990333f: [net processing] Refactor MaybeSendAddr().Jan 28 2022, 10:23

PiRK mentioned this in D16455: net processing, refactor: Decouple PeerManager from gArgs.Jul 12 2024, 08:57

PiRK mentioned this in rABCcdd9740bd3c3: net processing, refactor: Decouple PeerManager from gArgs.Jul 12 2024, 10:28

Revision Contents
Changeset List

Path

Size

src/

2 lines

6 lines

net_processing.cpp

10 lines

test/

functional/

48 lines

lint/

1 line

Diff 31794

src/init.cpp

Loading...

src/net.h

Loading...

src/net_processing.cpp

Loading...

test/functional/abc-cmdline.py

Loading...

test/lint/check-doc.py

Loading...