[Cashtab] Add background color to styled collapse
AbandonedPublic
Actions

Authored by kieran709 on Jan 18 2022, 21:20.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Summary

Added background color to styled collapse in StyledCollapse.js. Related to task T2174.

Test Plan

cd web/cashtab
npm start
navigate to the configure tab
ensure background colors for both StyledCollapse components are correct and that content is legible

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add-bg-color-styled-collapse

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17935
Build 35692: Build Diff	cashtab-tests
Build 35691: arc lint + arc unit

Event Timeline

kieran709 created this revision.Jan 18 2022, 21:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2022, 21:20

kieran709 requested review of this revision.Jan 18 2022, 21:20

Harbormaster completed remote builds in B17935: Diff 31838.Jan 18 2022, 21:23

kieran709 edited the summary of this revision. (Show Details)Jan 19 2022, 16:27

first level review is green

bytesofman requested changes to this revision.Jan 21 2022, 16:43

bytesofman added inline comments.

web/cashtab/src/components/Common/StyledCollapse.js
12	This is changing the color from white to grey. Please add a separate color under `props.theme.collapses`, say `props.theme.collapses.expandedBackground` For now, set it to white (the current color).