Differential D10861

test: Extend functional tests for addr relay
ClosedPublic
Actions

Authored by Fabien on Jan 21 2022, 11:34.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCc8c860300711: test: Extend functional tests for addr relay

Summary

This extends the functional test p2p_addr_relay.py.
It adds test coverage for address relay involving outbound peers, tests for both outgoing and incoming GETADDR requests and tests for -blocksonly mode.

Backport of core#21707, core#21785 (fix intermittent failure in the test) and core#22306 (improvements to p2p_addr_relay.py, also fixes an intermittent issue).

Note to reviewers: you can look at the file after #22306 to get the final version of the test.

Depends on D10860.

Ref T1696.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 21 2022, 11:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2022, 11:34

Fabien requested review of this revision.Jan 21 2022, 11:34

teamcity edited the summary of this revision. (Show Details)Jan 21 2022, 11:35

Harbormaster completed remote builds in B17967: Diff 31893.Jan 21 2022, 11:50

PiRK accepted this revision.Jan 21 2022, 13:20

PiRK added a subscriber: PiRK.

PiRK added inline comments.

test/functional/p2p_addr_relay.py
160–161 ↗	(On Diff #31893)	Not blocking, but just in case you touch the diff for another reason, you can fix the weird autopep8 auto-formatting mess.