Page MenuHomePhabricator
Differential D10867

[net processing] Rename nStartingHeight to m_starting_height
ClosedPublic
Actions

Authored by Fabien on Jan 24 2022, 11:03.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCa694ef7cc314: [net processing] Rename nStartingHeight to m_starting_height
Summary
Not done as a scripted diff to avoid misnaming the local variable in
ProcessMessage().

Partial backport of core#19829:
https://github.com/bitcoin/bitcoin/pull/19829/commits/78040f91687e7f1986e466d448c9b9530830e9b8

Depends on D10866.

Ref T1696.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 24 2022, 11:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2022, 11:03
Fabien requested review of this revision.Jan 24 2022, 11:03
Fabien added a child revision: D10868: [net processing] Move block inventory data to Peer.Jan 24 2022, 11:30
Harbormaster completed remote builds in B17974: Diff 31908.Jan 24 2022, 11:32
PiRK requested changes to this revision.Jan 24 2022, 13:05
PiRK added a subscriber: PiRK.

The summary is missing the PR# and commit. Otherwise, all good.

This revision now requires changes to proceed.Jan 24 2022, 13:05
Fabien edited the summary of this revision. (Show Details)Jan 24 2022, 13:41

Good catch

PiRK accepted this revision.Jan 24 2022, 13:46
This revision is now accepted and ready to land.Jan 24 2022, 13:46
Closed by commit rABCa694ef7cc314: [net processing] Rename nStartingHeight to m_starting_height (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 24 2022, 16:07
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa694ef7cc314: [net processing] Rename nStartingHeight to m_starting_height.

Revision Contents
Changeset List

PathSize
src/
2 lines
4 lines
17 lines
qt/
2 lines
rpc/
2 lines

Diff 31911

View Options

src/net.h

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...