Page MenuHomePhabricator
Differential D10871

[net processing] Move hashContinue to net processing
ClosedPublic
Actions

Authored by Fabien on Jan 24 2022, 16:23.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC3368e0a4576c: [net processing] Move hashContinue to net processing
Summary
Also rename to m_continuation_block to better communicate meaning.

Partial backport of core#19829:
https://github.com/bitcoin/bitcoin/pull/19829/commits/184557e8e03f76ff18dacdb32c12692d8578691f

Depends on D10870.

Ref T1696.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 24 2022, 16:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2022, 16:23
Fabien requested review of this revision.Jan 24 2022, 16:23
teamcity edited the summary of this revision. (Show Details)Jan 24 2022, 16:23
Fabien planned changes to this revision.Jan 24 2022, 16:28
Fabien updated this revision to Diff 31916.Jan 24 2022, 16:33

Fix a missing uint256 => BlockHash, and a comment layout

Fabien added a child revision: D10872: [net processing] Guard m_continuation_block with m_block_inv_mutex.Jan 24 2022, 16:39
Harbormaster completed remote builds in B17978: Diff 31915.Jan 24 2022, 16:56
Harbormaster completed remote builds in B17979: Diff 31916.Jan 24 2022, 17:01
PiRK accepted this revision.Jan 24 2022, 17:02
This revision is now accepted and ready to land.Jan 24 2022, 17:02
Closed by commit rABC3368e0a4576c: [net processing] Move hashContinue to net processing (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 24 2022, 19:44
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC3368e0a4576c: [net processing] Move hashContinue to net processing.

Revision Contents
Changeset List

PathSize
src/
2 lines
1 line
7 lines
11 lines

Diff 31919

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...