Page MenuHomePhabricator
Differential D10901

util: Allow use of C++14 chrono literals
ClosedPublic
Actions

Authored by Fabien on Jan 26 2022, 08:43.

Details

Reviewers
tyler-smith
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC14edfe57f116: util: Allow use of C++14 chrono literals
Summary
I think we should allow the use of chrono literals for new code to make it less verbose. Obviously old code can stay as-is.

This patch pulls in the needed namespace and replaces some lines for illustrative purposes.

Backport of core#20602.

Ref T1696.

Test Plan
ninja all check-all

Build for Windows.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 26 2022, 08:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 26 2022, 08:43
Fabien requested review of this revision.Jan 26 2022, 08:43
teamcity edited the summary of this revision. (Show Details)Jan 26 2022, 08:43
Fabien added a child revision: D10902: net: use std::chrono throughout maxOutbound logic.Jan 26 2022, 09:10
Harbormaster completed remote builds in B18017: Diff 31986.Jan 26 2022, 09:17
tyler-smith accepted this revision.Jan 26 2022, 09:59
tyler-smith added a subscriber: tyler-smith.

I don't have enough familiarity here to know if this is something we want to adopt, but it appears to be implemented correctly.

This revision is now accepted and ready to land.Jan 26 2022, 09:59
Closed by commit rABC14edfe57f116: util: Allow use of C++14 chrono literals (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJan 26 2022, 10:23
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC14edfe57f116: util: Allow use of C++14 chrono literals.

Revision Contents
Changeset List

PathSize
src/
3 lines
6 lines
3 lines
util/
2 lines

Diff 31990

View Options

src/net.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/randomenv.cpp

Loading...
View Options

src/util/time.h

Loading...