[net processing] Only call GetTime() once in SendMessages()
ClosedPublic
Actions

Authored by PiRK on Jan 27 2022, 16:06.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8c182804b605: [net processing] Only call GetTime() once in SendMessages()

Summary

We currently call GetTime() 4 times in SendMessages(). Consolidate this to once GetTime() call.

This is a backport of core#21236 [1/6]
https://github.com/bitcoin/bitcoin/pull/21236/commits/c02fa47baa517e17b5c43bde3902b1e410c1b93f

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18035
Build 35892: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35891: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 27 2022, 16:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2022, 16:06

PiRK requested review of this revision.Jan 27 2022, 16:06

teamcity edited the summary of this revision. (Show Details)Jan 27 2022, 16:07

PiRK added a child revision: D10916: [net] Change addr send times fields to be guarded by new mutex.Jan 27 2022, 16:09

Fabien accepted this revision.Jan 27 2022, 16:21

This revision is now accepted and ready to land.Jan 27 2022, 16:21

Harbormaster completed remote builds in B18035: Diff 32016.Jan 27 2022, 16:38

Closed by commit rABC8c182804b605: [net processing] Only call GetTime() once in SendMessages() (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyJan 28 2022, 07:09

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8c182804b605: [net processing] Only call GetTime() once in SendMessages().

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

21 lines

Diff 32016

View Options

[net processing] Only call GetTime() once in SendMessages()ClosedPublicActions