[net processing] Change MaybeSendAddr() to take a reference
ClosedPublic
Actions

Authored by PiRK on Jan 27 2022, 16:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC79cc0dca6fcc: [net processing] Change MaybeSendAddr() to take a reference

Summary

Change name of CNode parameter to node now that it's no longer a pointer.

This is a backport of core#21236 [4/6]
https://github.com/bitcoin/bitcoin/pull/21236/commits/c87423c58b5165de835a49bebd566538a70c07ab

Depends on D10917

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18038
Build 35898: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35897: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 27 2022, 16:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2022, 16:13

PiRK requested review of this revision.Jan 27 2022, 16:13

teamcity edited the summary of this revision. (Show Details)Jan 27 2022, 16:13

PiRK added a child revision: D10919: [net processing] Refactor MaybeSendAddr() - early exits.Jan 27 2022, 16:16

Fabien accepted this revision.Jan 27 2022, 16:57

This revision is now accepted and ready to land.Jan 27 2022, 16:57

Harbormaster completed remote builds in B18038: Diff 32019.Jan 27 2022, 16:59

Closed by commit rABC79cc0dca6fcc: [net processing] Change MaybeSendAddr() to take a reference (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyJan 28 2022, 07:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC79cc0dca6fcc: [net processing] Change MaybeSendAddr() to take a reference.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

48 lines

Diff 32019

View Options

[net processing] Change MaybeSendAddr() to take a referenceClosedPublicActions